Skip to content

Conversation

@dhurley
Copy link
Collaborator

@dhurley dhurley commented Nov 10, 2025

Proposed changes

Remotely configure NGINX Agent log level and path.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this Nov 10, 2025
@dhurley dhurley requested a review from a team as a code owner November 10, 2025 16:24
@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Nov 10, 2025
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 54.14013% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.04%. Comparing base (b55f22b) to head (e708254).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
internal/command/command_plugin.go 60.34% 19 Missing and 4 partials ⚠️
internal/collector/otel_collector_plugin.go 15.38% 11 Missing ⚠️
internal/file/file_plugin.go 35.29% 11 Missing ⚠️
internal/resource/resource_plugin.go 21.42% 11 Missing ⚠️
internal/watcher/watcher_plugin.go 15.38% 11 Missing ⚠️
internal/config/mapper.go 82.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
- Coverage   86.35%   86.04%   -0.32%     
==========================================
  Files         102      102              
  Lines       12510    12755     +245     
==========================================
+ Hits        10803    10975     +172     
- Misses       1230     1299      +69     
- Partials      477      481       +4     
Files with missing lines Coverage Δ
internal/command/command_service.go 81.70% <100.00%> (+1.32%) ⬆️
...ernal/watcher/instance/instance_watcher_service.go 76.54% <100.00%> (+0.10%) ⬆️
internal/config/mapper.go 70.65% <82.75%> (+5.57%) ⬆️
internal/collector/otel_collector_plugin.go 80.87% <15.38%> (-1.64%) ⬇️
internal/file/file_plugin.go 76.65% <35.29%> (-2.91%) ⬇️
internal/resource/resource_plugin.go 75.72% <21.42%> (-4.91%) ⬇️
internal/watcher/watcher_plugin.go 75.26% <15.38%> (-4.50%) ⬇️
internal/command/command_plugin.go 73.00% <60.34%> (-2.75%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55f22b...e708254. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}
slog.InfoContext(ctx, "Received management plane action request")
cp.handleAPIActionRequest(newCtx, message)
case *mpi.ManagementPlaneRequest_UpdateNginxAgentConfigurationRequest:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Auxiliary vs Command sever matter for the agent config ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks documentation Improvements or additions to documentation v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants