-
Notifications
You must be signed in to change notification settings - Fork 2k
extend cache policy for more configurable parameters #8533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cdf9ec9 to
9e4f62a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8533 +/- ##
==========================================
+ Coverage 53.65% 53.80% +0.14%
==========================================
Files 91 91
Lines 18476 18557 +81
==========================================
+ Hits 9913 9984 +71
- Misses 8043 8048 +5
- Partials 520 525 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7583cb7 to
a3f857a
Compare
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
a3f857a to
831fe94
Compare
Package Report
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx, 1.29.3-1~trixie, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-module-njs, 1.29.3+0.9.4-1~trixie, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-module-otel, 1.29.3+0.1.2-1~trixie, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-agent, 3.5.1~trixie, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx, 1.29.3-1~trixie, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-module-njs, 1.29.3+0.9.4-1~trixie, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-module-otel, 1.29.3+0.1.2-1~trixie, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-agent, 3.5.1~trixie, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus, 35-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-agent, 3.5.1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus, 35-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-njs, 35+0.9.1-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-otel, 35+0.1.2-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-fips-check, 35+0.1-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-agent, 3.5.1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus, 35-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-appprotect, 35+5.527.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, app-protect, 35+5.527.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, app-protect-attack-signatures, 2025.11.20-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, app-protect-threat-campaigns, 2025.11.24-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-agent, 2.44.0~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus, 35-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-appprotect, 35+5.527.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, app-protect-module-plus, 35+5.527.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, app-protect-plugin, 6.23.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-agent, 2.44.0~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus, 35-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-appprotectdos, 35+4.7.3-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, app-protect-dos, 35+4.7.3-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus, 35-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-appprotect, 35+5.527.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, app-protect, 35+5.527.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, app-protect-attack-signatures, 2025.11.20-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, app-protect-threat-campaigns, 2025.11.24-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-plus-module-appprotectdos, 35+4.7.3-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, app-protect-dos, 35+4.7.3-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1, nginx-agent, 2.44.0~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx, 1.29.3-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-module-njs, 1.29.3.0.9.4-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-module-otel, 1.29.3.0.1.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-agent, 3.5.1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx, 1.29.3-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-module-njs, 1.29.3.0.9.4-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-module-otel, 1.29.3.0.1.2-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-agent, 3.5.1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-plus, 35-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-plus-module-njs, 35.0.9.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-plus-module-otel, 35.0.1.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-plus-module-fips-check, 35.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-agent, 3.5.1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-plus, 35-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-plus-module-njs, 35.0.9.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-plus-module-otel, 35.0.1.2-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-plus-module-fips-check, 35.0.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine, nginx-agent, 3.5.1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus, 35-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-agent, 3.5.1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus, 35-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-agent, 3.5.1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus, 35-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-agent, 2.44.0, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-appprotect, 35.5.527.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, app-protect, 35.5.527.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, app-protect-attack-signatures, 2025.11.20-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, app-protect-threat-campaigns, 2025.11.24-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus, 35-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-agent, 2.44.0, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, nginx-plus-module-appprotect, 35.5.527.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, app-protect-module-plus, 35.5.527.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-alpine-fips, app-protect-plugin, 6.23.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx, 1.29.3-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-module-njs, 1.29.3+0.9.4-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-module-otel, 1.29.3+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-agent, 3.5.1-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx, 1.29.3-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-module-njs, 1.29.3+0.9.4-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-module-otel, 1.29.3+0.1.2-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-agent, 3.5.1-1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus, 35-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-agent, 3.5.1-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus, 35-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-agent, 3.5.1-1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus, 35-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-agent, 2.44.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-appprotect, 35+5.527.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, app-protect, 35+5.527.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, app-protect-attack-signatures, 2025.11.20-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, app-protect-threat-campaigns, 2025.11.24-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus, 35-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-agent, 2.44.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-appprotect, 35+5.527.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, app-protect-module-plus, 35+5.527.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, app-protect-plugin, 6.23.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, nginx-plus, 35-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, nginx-plus-module-njs, 35+0.9.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, nginx-plus-module-otel, 35+0.1.2-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, nginx-plus-module-fips-check, 35+0.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, nginx-agent, 2.44.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, nginx-plus-module-appprotect, 35+5.527.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, app-protect, 35+5.527.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, app-protect-attack-signatures, 2025.11.20-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, app-protect-threat-campaigns, 2025.11.24-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, nginx-plus, 35-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, nginx-plus-module-njs, 35+0.9.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, nginx-plus-module-otel, 35+0.1.2-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, nginx-plus-module-fips-check, 35+0.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, nginx-agent, 2.44.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, nginx-plus-module-appprotect, 35+5.527.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, app-protect-module-plus, 35+5.527.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi8, app-protect-plugin, 6.23.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus, 35-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-appprotectdos, 35+4.7.3-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, app-protect-dos, 35+4.7.3-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus, 35-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-appprotect, 35+5.527.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-plus-module-appprotectdos, 35+4.7.3-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, nginx-agent, 2.44.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, app-protect, 35+5.527.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, app-protect-attack-signatures, 2025.11.20-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, app-protect-threat-campaigns, 2025.11.24-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-3f2284f645ff659d9e1cbc648d90f6a1-ubi, app-protect-dos, 35+4.7.3-1.el9.ngx, x86_64 |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR extends the cache policy specification to support advanced NGINX caching parameters, enabling more granular control over cache behavior including cache management, locking mechanisms, conditional caching, and stale response handling.
Key Changes:
- Added advanced cache configuration fields including cache key customization, stale response handling, revalidation, background updates, and minimum use thresholds
- Introduced cache manager settings (files, sleep, threshold) for controlling cache cleanup behavior
- Added cache locking configuration to prevent cache stampede scenarios
- Implemented conditional caching with bypass and no-cache rules
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/apis/configuration/v1/types.go | Adds new cache-related struct types (CacheManager, CacheLock, CacheConditions) and extends Cache struct with advanced parameters |
| pkg/apis/configuration/validation/policy.go | Implements validation logic for new cache parameters including time formats, sizes, and use-stale conditions |
| internal/configs/virtualserver.go | Maps new cache policy fields from API types to version2 configuration structures with defaults |
| internal/configs/version2/http.go | Extends Cache and CacheZone structs with new fields and adds documentation for NGINX directive mapping |
| internal/configs/version2/nginx.virtualserver.tmpl | Updates template to render new cache directives (proxy_cache_key, proxy_cache_use_stale, etc.) |
| internal/configs/version2/nginx-plus.virtualserver.tmpl | Updates NGINX Plus template with same cache directive additions |
| pkg/apis/configuration/validation/policy_test.go | Adds comprehensive test cases for validating new cache parameters (both valid and invalid scenarios) |
| internal/configs/virtualserver_test.go | Updates existing tests and adds new test case for extended cache policy configuration |
| internal/configs/version2/templates_test.go | Adds new test for extended cache policy template rendering and updates expected cache zone declarations |
| tests/data/cache-policy/policies/cache-policy-advanced.yaml | Extends test policy with all new advanced cache parameters |
| deploy/crds.yaml, config/crd/bases/k8s.nginx.org_policies.yaml | Updates CRD definitions with new cache fields, validation rules, and documentation |
| docs/crd/k8s.nginx.org_policies.md | Documents all new cache policy fields in the API reference |
| examples/custom-resources/cache-policy/cache.yaml | Provides example usage of new cache configuration options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
javorszky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as all of my comments are nitpicks, and nginx does start up correctly if I set these values to 0s or 0k, though I don't know whether that just disables the relevant policy or it will break further down the line 🤔
Proposed changes
Policy:
conf:
cache contents:
Checklist
Before creating a PR, run through this checklist and mark each as complete.