How do you implement upsertMany?

[mmpneo]

Hey 👋!
In akita, we have store.upsertMany([])

My elf version:

load(data: ContentEntity[]) {
    store.update(
      // @ts-ignore
       ...data.map(v => upsertEntities(v.id, {updater: _ => v, creator: _ => v})),
      updateRequestStatus('load', 'success'));
  }

for some reason that map spread raises an argument error, but it works as expected.

So the question is: what is the closest thing to akita's upsertMany in elf?

[NetanelBasal]

Can you please describe the use case for upsertMany?

[mmpneo]

No, server returns only changes, be it totally new entity or update of existing. I'm sorry, my english sucks. I probably just cannot convey information properly

[NetanelBasal]

So there is a situation that you have X entities locally that the server doesn't return.

[mmpneo]

Yes, and i need to manipulate returned data only, old data should stay as is

[NetanelBasal]

I see. Ok, we'll implement it soon.

[mmpneo]

Thank you

[NetanelBasal]

@mmpneo any reason you can't use the following code?

load(data: ContentEntity[]) {
    store.update(
      upsertEntities(data.map(e => e.id), {updater: _ => v, creator: _ => v})),
      updateRequestStatus('load', 'success'));
  }

[mmpneo]

The following code won't even work, i think? updater and creator funcs are broken by nonexistent "v"?

[NetanelBasal]

I see what you mean. In the mean time you can do this:

  const data = [
    { id: 2, label: 'updated' },
    { id: 3, label: 'three' },
  ];

  todosStore.update(
    upsertEntities(
      data.map(({ id }) => id),
      {
        updater: (entity) => entity,
        creator(id) {
          return data.find((e) => e.id === id);
        },
      }
    )
  );

[NetanelBasal]

We'll solve this in an elegant way soon.

[leon]

I'm facing the same problem as above.

I find the upsertEntities function to be harder to grasp as a concept than just constructing an array of items I want to update and passing them to the store.

@NetanelBasal what api are you thinking of adding?

[NetanelBasal]

We'll change it to upsertEntitiesById and introduce the newest version of upsertEntities that will do what you need.

[leon]

This was implemented in v2

https://ngneat.github.io/elf/docs/features/entities/entities#upsertentities