Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Validation error in signup form #1172

Closed
2 of 3 tasks
deepakk33 opened this issue Nov 8, 2023 · 6 comments · Fixed by #1174
Closed
2 of 3 tasks

Bug: Validation error in signup form #1172

deepakk33 opened this issue Nov 8, 2023 · 6 comments · Fixed by #1174
Assignees
Labels
🐞 bug This is a patch, generally fixing some bugs. hacktoberfest This issue is a part of hacktoberfest 2023. invite me to the organisation Sends an invitation to your community organisation. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.

Comments

@deepakk33
Copy link

deepakk33 commented Nov 8, 2023

Description

Validation error should come inside form only rather than in form Toast massage , it will help user to catch error easily.

Proposed Solution

rather than using toast make object for every feild-state that can contains validation error as well so we can show error just below of the fields.

Screenshots

No response

Browser 🥦

Google Chrome

Checklist ✅

@deepakk33 deepakk33 added hacktoberfest This issue is a part of hacktoberfest 2023. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Nov 8, 2023
@github-project-automation github-project-automation bot moved this to Todo in Milan Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

Hello @deepakk33, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@Bashamega
Copy link

Hello:)
I am interested in solving this issue.
Can you assign me?

@tamalCodes
Copy link
Member

Hi @Bashamega , you can go forward with the issue.

📑 Checklist in case you missed something

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

@tamalCodes tamalCodes added status: wip 👩🏻‍💻 This issue/PR is actively being worked on. and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Nov 17, 2023
@tamalCodes tamalCodes moved this from Todo to In Progress (Issues) in Milan Nov 17, 2023
@Bashamega
Copy link

Bashamega commented Nov 17, 2023

Hi @Bashamega , you can go forward with the issue.

📑 Checklist in case you missed something

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

Thank you very much, but I am busy contributing to other projects. Sorry so much

@Endless8
Copy link
Contributor

Hey, I am willing to work on this issue

@tamalCodes tamalCodes assigned Endless8 and unassigned Bashamega Nov 21, 2023
@github-project-automation github-project-automation bot moved this from In Progress (Issues) to Merged/Discarded in Milan Nov 30, 2023
@tamalCodes tamalCodes added the invite me to the organisation Sends an invitation to your community organisation. label Mar 12, 2024
Copy link

Hi @tamalCodes, We just made a new organization, and have sent you an invite. Welcome to the community 🎉

Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/MilanCommunity/people

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. hacktoberfest This issue is a part of hacktoberfest 2023. invite me to the organisation Sends an invitation to your community organisation. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
Status: Merged/Discarded
Development

Successfully merging a pull request may close this issue.

4 participants