Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Password Hide Option Not Functioning in Sign In #1192

Closed
3 tasks done
NaveenChandraAdhikari opened this issue Jan 10, 2024 · 5 comments
Closed
3 tasks done
Labels
🐞 bug This is a patch, generally fixing some bugs. status: discuss 💬 Currently we are discussing about the further proceedings of the PR/issue.

Comments

@NaveenChandraAdhikari
Copy link

NaveenChandraAdhikari commented Jan 10, 2024

Description

This bug report addresses an issue where the "hide password" functionality is not working as intended. Users are unable to hide the password, which impacts the user experience negatively. This bug needs to be resolved promptly to ensure the proper functioning of the password hide option.
this issue creates problem not in sign in but also in Sign up Page TOO

Assigm me this under JWOC'24

Proposed Solution

debugging and fixing the js and HTMl markup fix the issue

Screenshots

Screenshot from 2024-01-11 02-12-54

Browser 🥦

Google Chrome

Checklist ✅

@NaveenChandraAdhikari NaveenChandraAdhikari added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Jan 10, 2024
@github-project-automation github-project-automation bot moved this to Todo in Milan Jan 10, 2024
Copy link

Hello @NaveenChandraAdhikari, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@Himanxu1
Copy link

It's working perfectly fine @NaveenChandraAdhikari

@tamalCodes
Copy link
Member

tamalCodes commented Jan 12, 2024

Same here, works fine for me too.

@NaveenChandraAdhikari , mind sharing a screen recording ?

@tamalCodes tamalCodes added status: discuss 💬 Currently we are discussing about the further proceedings of the PR/issue. and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jan 12, 2024
@NaveenChandraAdhikari
Copy link
Author

NaveenChandraAdhikari commented Jan 12, 2024

Apology: Issue Only Occurs on My Machine @tamalCodes but can I add Add Typewriter Effect to banner_header1 and Underlined Text effect while hover in Footer auth_text for better UI

@tamalCodes
Copy link
Member

Typewriter effects are generally considered bad UI both in terms of accessibility and SEO. I'll let that pass for now, i will be closing this issue.

@tamalCodes tamalCodes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2024
@github-project-automation github-project-automation bot moved this from Todo to Merged/Discarded in Milan Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. status: discuss 💬 Currently we are discussing about the further proceedings of the PR/issue.
Projects
Status: Merged/Discarded
Development

No branches or pull requests

3 participants