Skip to content

Commit 9942ce6

Browse files
committed
Revert "Do huffman encoding only when the reduction is more than 25%"
This reverts commit 8fd4bd8.
1 parent 594e2b3 commit 9942ce6

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lib/nghttp3_qpack.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1837,7 +1837,7 @@ static int qpack_encoder_write_indexed_name(nghttp3_qpack_encoder *encoder,
18371837
int h = 0;
18381838

18391839
hlen = nghttp3_qpack_huffman_encode_count(nv->value, nv->valuelen);
1840-
if (hlen * 4 < nv->valuelen * 3) {
1840+
if (hlen < nv->valuelen) {
18411841
h = 1;
18421842
len += nghttp3_qpack_put_varint_len(hlen, 7) + hlen;
18431843
} else {
@@ -1928,15 +1928,15 @@ static int qpack_encoder_write_literal(nghttp3_qpack_encoder *encoder,
19281928
int nh = 0, vh = 0;
19291929

19301930
nhlen = nghttp3_qpack_huffman_encode_count(nv->name, nv->namelen);
1931-
if (nhlen * 4 < nv->namelen * 3) {
1931+
if (nhlen < nv->namelen) {
19321932
nh = 1;
19331933
len = nghttp3_qpack_put_varint_len(nhlen, prefix) + nhlen;
19341934
} else {
19351935
len = nghttp3_qpack_put_varint_len(nv->namelen, prefix) + nv->namelen;
19361936
}
19371937

19381938
vhlen = nghttp3_qpack_huffman_encode_count(nv->value, nv->valuelen);
1939-
if (vhlen * 4 < nv->valuelen * 3) {
1939+
if (vhlen < nv->valuelen) {
19401940
vh = 1;
19411941
len += nghttp3_qpack_put_varint_len(vhlen, 7) + vhlen;
19421942
} else {

0 commit comments

Comments
 (0)