Add more coverage

Author: nhatthm

installer.go

@@ -5,7 +5,6 @@ import (
 	"errors"
 	"fmt"
 	"net/http"
-	"net/url"
 	"path/filepath"
 	"sync"
 
@@ -50,8 +49,6 @@ type Installer struct {
 	fs      afero.Fs
 	service RepositoryService
 
-	baseURL *url.URL
-
 	mu sync.Mutex
 }
 
@@ -205,22 +202,12 @@ func NewInstaller(fs afero.Fs, options ...Option) *Installer {
 	}
 
 	if i.service == nil {
-		c := github.NewClient(nil)
-		c.BaseURL = i.baseURL
-
-		i.service = c.Repositories
+		i.service = github.NewClient(nil).Repositories
 	}
 
 	return i
 }
 
-// WithBaseURL sets the base url for github client.
-func WithBaseURL(url *url.URL) Option {
-	return func(i *Installer) {
-		i.baseURL = url
-	}
-}
-
 // WithService sets the repository service.
 func WithService(service RepositoryService) Option {
 	return func(i *Installer) {

installer_test.go

@@ -105,6 +105,19 @@ func TestInstaller_Install(t *testing.T) {
 			}),
 			expectedError: "could not load plugin metadata: EOF",
 		},
+		{
+			scenario: "could not find artifact (no artifact)",
+			source:   "github.com/owner/my-plugin@v1.4.2",
+			mockService: service.MockRepositoryService(func(s *service.RepositoryService) {
+				s.On("GetReleaseByTag", mock.Anything, "owner", "my-plugin", "v1.4.2").
+					Return(newRelease("v1.4.2"), nil, nil)
+
+				s.On("DownloadContents", mock.Anything, "owner", "my-plugin", ".plugin.registry.yaml",
+					&goGitHub.RepositoryContentGetOptions{Ref: "v1.4.2"}).
+					Return(newMetadataFile("resources/fixtures/.plugin.registry.yaml"), nil, nil)
+			}),
+			expectedError: "could not find artifact: artifact not found",
+		},
 		{
 			scenario: "could not find artifact",
 			source:   "github.com/owner/my-plugin@v1.4.2",