Merge pull request #52 from nhsuk/feature/prefer-destructuring

✨ Turn on prefer-destructuring option

Author: neilbmclaughlin

.eslintrc.js

@@ -44,7 +44,16 @@ module.exports = {
         allowForLoopAfterthoughts: true,
       },
     ],
-    'prefer-destructuring': 'off',
+    'prefer-destructuring': [
+      'error',
+      {
+        array: true,
+        object: true,
+      },
+      {
+        enforceForRenamedProperties: true,
+      },
+    ],
     'sort-keys': [
       'error',
       'asc',

CHANGELOG.md

@@ -1,6 +1,8 @@
-0.22.0 / TBC
+0.22.0 / 2019-10-08
 ===================
 - Disallow empty lines at BOF and EOF
+- Turn `prefer-destructuring` on for both `object` and `array`
+- Update npm dependencies
 
 0.21.2 / 2019-09-25
 ===================

test/index.js

@@ -1,8 +1,8 @@
-const CLIEngine = require('eslint').CLIEngine;
+const { CLIEngine } = require('eslint');
 const chai = require('chai');
 const rules = require('../.eslintrc');
 
-const expect = chai.expect;
+const { expect } = chai;
 
 describe('the ruleset exported from index.js', () => {
   it('should not flag any errors or warnings when linting the code base', () => {
@@ -11,16 +11,15 @@ describe('the ruleset exported from index.js', () => {
 
     const report = cli.executeOnFiles(['.']);
 
-    const errors = report.errorCount;
-    const warnings = report.warningCount;
+    const { errorCount, warningCount } = report;
 
-    if (errors + warnings > 0) {
+    if (errorCount + warningCount > 0) {
       const formatter = cli.getFormatter();
       // eslint-disable-next-line no-console
       console.error(formatter(report.results));
     }
 
-    expect(errors).to.be.equal(0);
-    expect(warnings).to.be.equal(0);
+    expect(errorCount).to.be.equal(0);
+    expect(warningCount).to.be.equal(0);
   });
 });