Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline context help for nimble-combobox #1592

Closed
3 tasks
mure opened this issue Oct 9, 2023 · 4 comments
Closed
3 tasks

Inline context help for nimble-combobox #1592

mure opened this issue Oct 9, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request interaction design Interaction design work item needs investigation Further research is needed to identify solution

Comments

@mure
Copy link

mure commented Oct 9, 2023

😯 Problem to Solve

Hi all - I'm starting to look at ⁠this feature, part of the new routines UX that requires Nimble updates.

The goal of the feature is to be able to display inline help for the workspace selector field. The current wireframes show this UX:

image

Hovering the ℹ️ icon would display a tooltip. This would require changes to the nimble-combobox.

💁 Proposed Solution

I'm anticipating pushback on the UX above, mostly because it conflicts with the existing UX for displaying validation errors:

image

My proposal would be to move the tooltip hover icon into the component's label. This approach can apply to all form controls, so it's both easier to implement and less cognitive load for users.

Here's an example of how Grafana's design system does inline help:

image

My intent for this issue is to come to a consensus on the correct UX and implementation for the feature. Based on the outcome, I can create a spec if needed. My understanding is that we'll also need to create or update an IxD spec.

🙋‍♂️ Open issues

  • Decide on UX of inline help for form controls
  • I noticed in Storybook that the combobox doesn't seem to have a label attribute. Will we need to add this?
  • Should we resurrect the nimble-tooltip for this feature?
@mure mure added enhancement New feature or request triage New issue that needs to be reviewed labels Oct 9, 2023
@m-akinc m-akinc added interaction design Interaction design work item needs investigation Further research is needed to identify solution and removed triage New issue that needs to be reviewed labels Oct 10, 2023
@m-akinc
Copy link
Contributor

m-akinc commented Oct 10, 2023

@mure, please set up a meeting with @leslieab, @NIbokeefe, and @mollykreis to discuss direction.

@mollykreis mollykreis added the triage New issue that needs to be reviewed label Feb 15, 2024
@mollykreis
Copy link
Contributor

This has come up again in SLE apps.

Draft PR of creating an Angular directive to work around this feature missing from nimble: https://dev.azure.com/ni/DevCentral/_git/Skyline/pullrequest/646253?_a=files&path=/Web/Workspaces/LabManagement/src/app/context-help.directive.ts

@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Feb 20, 2024
@jattasNI
Copy link
Contributor

jattasNI commented Feb 20, 2024

Visual design is available as nimble-toggle-tip.

There are open interaction questions like:

  • what is the keyboard interaction? Does it capture focus on keyboard and mouse interactions?
  • are there any touch interactions?
  • what is the presentation in the accessibility tree?
  • does this need different severity states like error and info?

We decided to allow SLE to build a shared version with some hacks to reach into the shadow DOM while we work on resolving these questions and building a Nimble version.

@fredvisser
Copy link
Contributor

Closing in favor of #1876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request interaction design Interaction design work item needs investigation Further research is needed to identify solution
Projects
Development

No branches or pull requests

5 participants