Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align rich-text mention listbox implementation behavior #1926

Open
Tracked by #1948
rajsite opened this issue Mar 12, 2024 · 0 comments
Open
Tracked by #1948

Align rich-text mention listbox implementation behavior #1926

rajsite opened this issue Mar 12, 2024 · 0 comments

Comments

@rajsite
Copy link
Member

rajsite commented Mar 12, 2024

🧹 Tech Debt

In discussions with @atmgrifter00 in #1912, as part of preventing arbitrary differences between all of our Foundation ListBox implementations (select, combobox, mentions listbox) it was found that the implementation in the mention list box:

  1. Does not handle filteredOptions in a way that aligns with the select (as filtering is done the list of options is mutated which state-wise seems unexpected)
  2. The mention listbox does not handle the synchronous option registration behavior added to select and combobox in Angular Select placeholder integration #1912.
  3. Introduced as part of this PR, the Select will no longer style the "selected" option in the dropdown with the aria-selected attribute, and instead leverage a new active-option attribute. This allows us to keep the aria-selected attribute synchronized with the actual option that is currently representative of the value of the Select. The mentions listbox and combobox should adopt this same pattern (which should result in some CSS moving from the Select styles to the ListOption styles).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Top Tech Debt
Development

No branches or pull requests

2 participants