You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In discussions with @atmgrifter00 in #1912, as part of preventing arbitrary differences between all of our Foundation ListBox implementations (select, combobox, mentions listbox) it was found that the implementation in the mention list box:
Does not handle filteredOptions in a way that aligns with the select (as filtering is done the list of options is mutated which state-wise seems unexpected)
Introduced as part of this PR, the Select will no longer style the "selected" option in the dropdown with the aria-selected attribute, and instead leverage a new active-option attribute. This allows us to keep the aria-selected attribute synchronized with the actual option that is currently representative of the value of the Select. The mentions listbox and combobox should adopt this same pattern (which should result in some CSS moving from the Select styles to the ListOption styles).
The text was updated successfully, but these errors were encountered:
🧹 Tech Debt
In discussions with @atmgrifter00 in #1912, as part of preventing arbitrary differences between all of our Foundation ListBox implementations (select, combobox, mentions listbox) it was found that the implementation in the mention list box:
Select
will no longer style the "selected" option in the dropdown with thearia-selected
attribute, and instead leverage a newactive-option
attribute. This allows us to keep thearia-selected
attribute synchronized with the actual option that is currently representative of the value of theSelect
. The mentions listbox and combobox should adopt this same pattern (which should result in some CSS moving from theSelect
styles to theListOption
styles).The text was updated successfully, but these errors were encountered: