Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error text on components should only have title when content overflows #2431

Open
mollykreis opened this issue Oct 9, 2024 · 0 comments · May be fixed by #2432
Open

Error text on components should only have title when content overflows #2431

mollykreis opened this issue Oct 9, 2024 · 0 comments · May be fixed by #2432
Assignees
Labels
bug Something isn't working

Comments

@mollykreis
Copy link
Contributor

🐛 Bug Report

The error text on nimble components should only have a title when the error text content overflows. However, the errorTextTemplate currently adds a title all the time, which is both unnecessary and against the current patterns within nimble. The template should use the overflow directive to only add a title when the error text content doesn't fit.

💻 Repro or Code Sample

🤔 Expected Behavior

The error text under a component should only have a title if the error text content doesn't fit in the allocated width of the control.

😯 Current Behavior

The error text under a component always has a title.

💁 Possible Solution

Use the overflow directive.

🔦 Context

🌍 Your Environment

  • OS & Device: [e.g. MacOS, iOS, Windows, Linux] on [iPhone 7, PC]
  • Browser [e.g. Microsoft Edge, Google Chrome, Apple Safari, Mozilla FireFox]
  • Version [e.g. 1.8.0]
@mollykreis mollykreis added bug Something isn't working triage New issue that needs to be reviewed labels Oct 9, 2024
@mollykreis mollykreis self-assigned this Oct 9, 2024
This was referenced Oct 9, 2024
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Oct 15, 2024
@mollykreis mollykreis changed the title Error text on components should only have title when content overlows Error text on components should only have title when content overflows Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants