Incorrect aria-hidden for non-focusable buttons

[rajsite]

🐛 Bug Report

Some button interactions are non-focusable due to aria patterns where alternate keyboard interactions are expected:

• inc/dec buttons on numeric
• dropdown button on select / combobox
• next/prev buttons on tabs

Our current pattern has been to remove those buttons from the aria tree via aria-hidden. However based on discussions in the scrollable tabs PR it seems like removing the buttons from aria all together is not the right direction.

Specifically as an example, the spin button pattern example describes of the inc/dec buttons as the following:

The increase and decrease buttons are not contained within the div with role spinbutton so they can be separately focusable by users of touch screen readers. However, they are excluded from the page Tab sequence with tabindex="-1" because they are redundant with the arrow key support provided to keyboard users.

This issue is to cover our other non-focusable buttons to make sure they are exposed to aria correctly.

💻 Repro or Code Sample

See above.

🤔 Expected Behavior

Non-focusable buttons are still in the aria tree and have correct aria labels

😯 Current Behavior

Non-focusable buttons are aria hidden.

💁 Possible Solution

See above.

🔦 Context

N/A

🌍 Your Environment

N/A