Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent storybook from mutating the built package contents #568

Closed
rajsite opened this issue May 18, 2022 · 2 comments
Closed

Prevent storybook from mutating the built package contents #568

rajsite opened this issue May 18, 2022 · 2 comments

Comments

@rajsite
Copy link
Member

rajsite commented May 18, 2022

🧹 Tech Debt

Currently storybook's build creates a duplicate copy of the typescript type files in nimble components.

See how in the following package there is the typescript build output:
https://unpkg.com/browse/@ni/nimble-components@9.0.4/dist/esm/

And inside the typescript build output there is a duplicate of the typescript d.ts type files in the folder nimble-components:
https://unpkg.com/browse/@ni/nimble-components@9.0.4/dist/esm/nimble-components/src/

Those files were excluded in #567 in a gitignore but we should find out how to prevent storybook from mutating that folder.

@rajsite rajsite added tech debt triage New issue that needs to be reviewed labels May 18, 2022
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label May 24, 2022
@rajsite
Copy link
Member Author

rajsite commented Jan 4, 2024

This regressed and had to be resolved again: #1558

Still haven't thought of a great way to prevent the regression. One thought was storybook should be in it's own package (so that it could rely on a nimble-react package generated from nimble-components). If that happened this would be resolved since stroybook wouldn't be directly involved in the components build.

@rajsite
Copy link
Member Author

rajsite commented Jan 11, 2024

Closing in favor of #1747 which gives a way to manually validate (though open to other ideas)

@rajsite rajsite closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants