From 6eac1829061392fc1bbbff7a3477182a384b9773 Mon Sep 17 00:00:00 2001 From: Fred Visser <1458528+fredvisser@users.noreply.github.com> Date: Fri, 24 May 2024 14:36:52 -0500 Subject: [PATCH 1/2] icon request template --- .github/ISSUE_TEMPLATE/icon-request.md | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/icon-request.md diff --git a/.github/ISSUE_TEMPLATE/icon-request.md b/.github/ISSUE_TEMPLATE/icon-request.md new file mode 100644 index 0000000000..c641adcd47 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/icon-request.md @@ -0,0 +1,25 @@ +--- +name: ๐ŸŽจ Icon Design Request +about: Icon design request for a Visual Designer +title: '{icon metaphor} icon request' +labels: 'visual design,triage,icon request' +--- + + + +# ๐ŸŽจ Icon Request + +## ๐Ÿ“Œ Request Background + + + +## ๐Ÿงช Research + + + + +## ๐Ÿฅ… Acceptance Criteria + +- [ ] Icon reviewed by design team +- [ ] Icon available in [Nimble_Iconography](https://www.figma.com/design/aOmrur2iA2Abc6Pp59NVGV/Nimble_Iconography?node-id=0-1&t=KGtldxWuPIvzgHCo-0) (link) +- [ ] Icon published in Nimble Storybook (link) From 32b5a7ab018efd554833517e9bb0fffb9192410c Mon Sep 17 00:00:00 2001 From: Fred Visser <1458528+fredvisser@users.noreply.github.com> Date: Fri, 31 May 2024 12:38:20 -0500 Subject: [PATCH 2/2] review feedback - link to issue from story --- packages/storybook/src/nimble/icon-base/icons.mdx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/storybook/src/nimble/icon-base/icons.mdx b/packages/storybook/src/nimble/icon-base/icons.mdx index ec28df3efc..6b2e33d928 100644 --- a/packages/storybook/src/nimble/icon-base/icons.mdx +++ b/packages/storybook/src/nimble/icon-base/icons.mdx @@ -7,6 +7,8 @@ import { iconAddTag } from '../../../../nimble-components/src/icons/add'; Nimble icons can be slotted into other components or used independently. Each icon is available as a custom element. For example, . +If you need a new icon, please [submit an issue](https://github.com/ni/nimble/issues/new/choose) using the "Icon Design Request" template. +