-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap to turn classylss into a CLASS binding. #12
Comments
Yes, I think I agree with this. A few questions:
|
|
Yes, I think I would prefer to push on this and get everything working by the end of the month...I can start working on this as well asap |
okay @rainwoodman, here's what I am thinking for the next steps:
|
I think we shall advertise classylss -- I am not sure where to. Consider adding a few examples? |
I can try to put together a bare bone RTD with some examples for #18 -- shouldn't be too hard. |
The CLASS developers are aware? It would be good to avoid any potential friction caused by the fact that they have their own binding (I am not sure how well-maintained their binding is?). We could potentially advertise on the astronomer's FB page? I am not sure if that is an okay thing to do... |
It is not yet well maintained, at least not to the level of classylss. The best case scenario is to make classylss the go to binding and build a good channel with the class_public development. What about adding the two we have patches as PR to If history is a lesson I remember there was a third party binding before and it stopped being developed or used. Then the class developer also agreed their current binding is insufficient in one of the posts. |
Here is what I propose as a roadmap.
Implement pure python classylss.cosmology that can be constructed from Astropy cosmology objects, and yet delegates to CLASS for all function evaluation,
Reimplement a classylss.lss module that contains original functionalities of classylss.legacy, but in pure python, using mcfit.
migrate classylss.cosmology and lss to nbodykit. Now classylss contains only class binding, and nbodykit doesn't contain any compiled code.
Move the original lss routines to a classylss.legacy module. We break all code that uses classylss at this step, such that they can be clearly grepped and switch to nbodykit when necessary.
The text was updated successfully, but these errors were encountered: