Remove SepReader.Col.ToStringRaw from public API (#65)

With unescape "Raw" becomes confusing as users may think this means no
unescaping while it's intend was to mean unpooled, it has therefore been
made internal and renamed to `ToStringDirect`.

Author: nietras

README.md

@@ -1258,7 +1258,6 @@ namespace nietras.SeparatedValues
             public T Parse<T>()
                 where T : System.ISpanParsable<T> { }
             public override string ToString() { }
-            public string ToStringRaw() { }
             public T? TryParse<T>()
                 where T :  struct, System.ISpanParsable<T> { }
             public bool TryParse<T>(out T value)

src/Sep.Test/SepReaderColTest.cs

@@ -40,9 +40,9 @@ public void SepReaderColTest_ToString()
     }
 
     [TestMethod]
-    public void SepReaderColTest_ToStringRaw()
+    public void SepReaderColTest_ToStringDirect()
     {
-        Run(col => Assert.AreEqual(ColText, col.ToStringRaw()));
+        Run(col => Assert.AreEqual(ColText, col.ToStringDirect()));
         Run(col => Assert.AreSame(string.Empty, col.ToString()), "");
     }
 

src/Sep.Test/SepReaderColsTest.cs

@@ -172,9 +172,9 @@ public unsafe void SepReaderColsTest_Select_MethodPointer_ToString()
     }
 
     [TestMethod]
-    public void SepReaderColsTest_Select_ToStringRaw()
+    public void SepReaderColsTest_Select_ToStringDirect()
     {
-        Run((cols, range) => CollectionAssert.AreEqual(_colTexts[range], cols.Select(c => c.ToStringRaw()).ToArray()));
+        Run((cols, range) => CollectionAssert.AreEqual(_colTexts[range], cols.Select(c => c.ToStringDirect()).ToArray()));
     }
 
     static string ToString(SepReader.Col col) => col.ToString();

src/Sep/CompatibilitySuppressions.xml

@@ -1,6 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
 <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+  <Suppression>
+    <DiagnosticId>CP0002</DiagnosticId>
+    <Target>M:nietras.SeparatedValues.SepReader.Col.ToStringRaw</Target>
+    <Left>lib/net7.0/Sep.dll</Left>
+    <Right>lib/net7.0/Sep.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
   <Suppression>
     <DiagnosticId>CP0002</DiagnosticId>
     <Target>M:nietras.SeparatedValues.SepReader.Cols.get_Length</Target>

src/Sep/SepReader.Col.cs

@@ -26,7 +26,7 @@ internal Col(SepReaderState state, int colIndex)
 
         // Allow opt out of pooling and don't add yet another configuration option
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public string ToStringRaw() => _state.ToStringRaw(_colIndex);
+        internal string ToStringDirect() => _state.ToStringDirect(_colIndex);
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public T Parse<T>() where T : ISpanParsable<T> => _state.Parse<T>(_colIndex);

src/Sep/SepReader.Row.cs

@@ -200,7 +200,7 @@ ColDebugView[] GetCols()
                 var maybeHeader = _state._hasHeader ? _state._header : null;
                 for (var colIndex = 0; colIndex < cols.Length; colIndex++)
                 {
-                    var colValue = row[colIndex].ToStringRaw();
+                    var colValue = row[colIndex].ToStringDirect();
                     cols[colIndex] = new(colIndex, maybeHeader?.ColNames[colIndex], colValue);
                 }
                 return cols;

src/Sep/SepReader.cs

@@ -113,7 +113,7 @@ internal void Initialize(SepReaderOptions options)
                 var colNameToIndex = new Dictionary<string, int>(_colCount);
                 for (var colIndex = 0; colIndex < _colCount; colIndex++)
                 {
-                    var colName = ToStringRaw(colIndex);
+                    var colName = ToStringDirect(colIndex);
                     colNameToIndex.Add(colName, colIndex);
                 }
                 var headerRow = new string(RowSpan());

src/Sep/SepReaderState.cs

@@ -169,7 +169,7 @@ internal string ToStringDefault(int index)
         return _toString.ToString(span, index);
     }
 
-    internal string ToStringRaw(int index)
+    internal string ToStringDirect(int index)
     {
         var span = GetColSpan(index);
         var s = TryGetStaticallyCachedString(span);