-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
P3: lowNice to have — polish, cleanup, or long-termNice to have — polish, cleanup, or long-termenhancementNew feature or requestNew feature or request
Description
Description
The standalone mc_pr tool (updated in #38) loads PR templates from .github/pull_request_template.md and 4 other candidate paths. The plan orchestrator's createPR() method in orchestrator.ts does not — it generates its own body with a job status table but completely ignores the project's PR template.
This means:
- Standalone jobs (
mc_launch→mc_pr): PR uses the project template ✅ - Plan jobs (
mc_plan→ auto PR): PR ignores the project template ❌
Current Behavior
orchestrator.ts createPR() builds a hardcoded body:
const body = [
'## Summary',
`Orchestrated plan **${plan.name}** with ${plan.jobs.length} job(s).`,
'## Jobs',
// ... job table
'## Testing',
// ... test info
].join('\n');No template loading. No awareness of .github/pull_request_template.md.
Expected Behavior
The orchestrator should:
- Load the PR template (using the same
loadPrTemplate()fromsrc/tools/pr.tsor a shared utility) - Populate the template sections with plan-specific data (job table, test results)
- Fall back to the current generated body if no template exists
Proposed Solution
- Extract
loadPrTemplate()fromsrc/tools/pr.tsinto a shared utility (e.g.,src/lib/pr-template.ts) - In
orchestrator.tscreatePR():- Load the template
- If template exists, populate
## Summarywith plan description,## Changeswith job table,## Testingwith test results,## Noteswith integration metadata - If no template, use the current generated body
- Import and use the shared utility in both
mc_prandorchestrator.ts
Files
src/tools/pr.ts— extractloadPrTemplate()to shared utilitysrc/lib/orchestrator.ts— use template increatePR()- New:
src/lib/pr-template.ts— shared template loading utility
Priority
P3 — cosmetic improvement. PRs still get created, just without the template structure.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3: lowNice to have — polish, cleanup, or long-termNice to have — polish, cleanup, or long-termenhancementNew feature or requestNew feature or request