Fix resource leak.

0-wiz-0 · 0-wiz-0 · commit 9ce1c23a1003 · 2024-12-02T20:57:28.000+01:00
Coverity CID 1635798.
diff --git a/lib/zip_close.c b/lib/zip_close.c
@@ -515,11 +515,13 @@ static int add_data(zip_t *za, zip_source_t *src, zip_dirent_t *de, zip_uint32_t
 
     /* as long as we don't support non-seekable output, clear data descriptor bit */
     if ((is_zip64 = _zip_dirent_write(za, de, flags)) < 0) {
+        zip_source_free(src_final);
         return -1;
     }
 
     if ((offdata = zip_source_tell_write(za->src)) < 0) {
         zip_error_set_from_source(&za->error, za->src);
+        zip_source_free(src_final);
         return -1;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -515,11 +515,13 @@ static int add_data(zip_t za, zip_source_t src, zip_dirent_t *de, zip_uint32_t`
`515`	`515`
`516`	`516`	`/* as long as we don't support non-seekable output, clear data descriptor bit */`
`517`	`517`	`if ((is_zip64 = _zip_dirent_write(za, de, flags)) < 0) {`
	`518`	`+ zip_source_free(src_final);`
`518`	`519`	`return -1;`
`519`	`520`	`}`
`520`	`521`
`521`	`522`	`if ((offdata = zip_source_tell_write(za->src)) < 0) {`
`522`	`523`	`zip_error_set_from_source(&za->error, za->src);`
	`524`	`+ zip_source_free(src_final);`
`523`	`525`	`return -1;`
`524`	`526`	`}`
`525`	`527`