Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some BGCOLOR's don't work in Edotor #48

Open
ghost opened this issue May 4, 2022 · 2 comments
Open

Some BGCOLOR's don't work in Edotor #48

ghost opened this issue May 4, 2022 · 2 comments

Comments

@ghost
Copy link

ghost commented May 4, 2022

Stumbled upon this while reviewing a pull request from another repo:

It appears not all BGCOLOR values work in Edotor, the following always show as black as shown in this example

  • DARKRED
  • FUCHSIA
  • REBECCAPURPLE
  • DARKMAGENTA
  • LIME
  • LIGHTGREEN
  • OLIVE
  • DARKCYAN
  • TEAL
  • AQUA
  • DARKBLUE
  • SILVER
  • DARKGRAY

Another web editor shows these colours without a problem.
@nikeee nikeee mentioned this issue May 4, 2022
Closed
@nikeee
Copy link
Owner

nikeee commented May 4, 2022 •
edited
Loading

Now fixed in core library:
nikeee/dot-language-support@c724aac

Porting this over to edotor.

@nikeee
Copy link
Owner

nikeee commented May 4, 2022 •
edited
Loading

This is just for the auto completion, though. It seems that they were added in a newer version of GraphViz.

We're using a divverent rendering library than the site you linked (they use D3, edotor uses viz.js, which is the actual Graphviz).

It it likely that we need a new build of viz.js for this to work:
https://github.com/mdaines/viz.js

Working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikeee