-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Meet PIP pop up not detected as a dialog #933
Comments
Google chrome is excluded from the heuristic because if you drag a tab into a separate window, the window doesn't have the fullscreen button for a few firsts seconds If you find a way to distinguish dragged tab vs Google meet popup, I will happily accept your PR The pointer in the source code: |
Unfortunately swift is a bit outside of my area of expertise. I think it could be targeted based on title as the title format is slightly different than a standard chrome tab, let me see if that works. |
The following seems to work for me: [[on-window-detected]]
if.app-id = 'com.google.Chrome'
if.window-title-regex-substring = '^about:blank - (?!Google Chrome).*$'
run = ['layout floating'] Standard chrome windows seem to be format |
Closing in favor of #1001 |
Per the docs, windows that don't have minimize/maximize should be detected as dialog. I believe based on the debug output, these windows lack this (I assume
AXEnabled: Optional(0)
?)Debug output, username
[REDACTED]
The text was updated successfully, but these errors were encountered: