Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find authors by olid #2

Open
nithinbekal opened this issue May 5, 2017 · 6 comments
Open

Find authors by olid #2

nithinbekal opened this issue May 5, 2017 · 6 comments
Milestone

Comments

@nithinbekal
Copy link
Owner

Implement Openlibrary.Author.find_by_olid/1.

Refer:

@nithinbekal nithinbekal changed the title Find authors by olid Find authors by olid May 5, 2017
@nithinbekal
Copy link
Owner Author

Fixed via #6. Thanks @nithinjos!

@nithinjos
Copy link
Contributor

Thanks and Cheers @nithinbekal , but I'm afraid I didn't add the find_by_olid function which was the 2nd issue reported. Let me create one more PR ?

@nithinbekal
Copy link
Owner Author

That would be awesome! I saw the find_by_oclc function and misread that as olid. :)

@nithinbekal nithinbekal reopened this May 7, 2017
@nithinbekal nithinbekal modified the milestone: 0.2.0 May 7, 2017
@nithinjos
Copy link
Contributor

nithinjos commented May 7, 2017

I'll do it soon. Also, apart from these three raised issues, what are the other functions to be added to Openlibrary? I'd like to work on it :) :)

@nithinbekal
Copy link
Owner Author

There are things in the API that aren't included yet, like searching multiple keys, looking up authors, etc. I'll add them as issues - feel free to take them up. :)

@nithinjos
Copy link
Contributor

Sure! @nithinbekal :) Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants