defineCachedFunction ignores function name

[IlyaSemenov]

Environment

nitropack 2.10.4

Reproduction

https://stackblitz.com/edit/github-9uizvfes?file=server%2Froutes%2Findex.ts

Misbehaving code from the repro:

async function _foo() {
  return 'FOO';
}

const foo = defineCachedFunction(_foo);

async function _bar() {
  await new Promise((resolve) => setTimeout(resolve, 1));
  return 'BAR';
}

const bar = defineCachedFunction(_bar);

async function main() {
  // Expected: FOO BAR
  // Actual result: FOO FOO
  console.log(await foo());
  await new Promise((resolve) => setTimeout(resolve, 100));
  console.log(await bar());
}

main();

Describe the bug

defineCachedFunction is supposed to guess cache key from the function name, and only use _ as a fall back:

Guessed from function name if not provided, and falls back to '_' otherwise.

However, name is never taken from the function, _ is always used. This is due to bug where the default is taken before looking up function name:

nitro/src/runtime/internal/cache.ts

Lines 40 to 46 in 005a74f

	opts = { ...defaultCacheOptions(), ...opts };
	const pending: { [key: string]: Promise<T> } = {};
	// Normalize cache params
	const group = opts.group || "nitro/functions";
	const name = opts.name || fn.name || "_";

As you can see opts.name is taken first, which comes from defaultCacheOptions(), which always returns { name: "_" }.

nitro/src/runtime/internal/cache.ts

Lines 25 to 32 in 005a74f

	function defaultCacheOptions() {
	return {
	name: "_",
	base: "/cache",
	swr: true,
	maxAge: 1,
	} as const;
	}

Additional context

No response

Logs