Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple locations for a track #17

Open
gordielachance opened this issue Mar 25, 2020 · 5 comments
Open

support multiple locations for a track #17

gordielachance opened this issue Mar 25, 2020 · 5 comments

Comments

@gordielachance
Copy link

Hi,
The XSPF specs do support multiple locations for a track, which you should probably reflect in your code.
Thanks !

@njh
Copy link
Owner

njh commented Apr 5, 2020

Would the following work for you?

track.locations      # Get array of locations for a track
track.locations = [] # Assign multiple locations to a track
track.location       # Get the first location
track.location =     # Set the first location

@gordielachance
Copy link
Author

It would work, if the XSPF is rendered correctly (as location and not locations).

If it was me, I would just use track.locations in the Ruby code.
Having both a plural and singular form seems confusing to me.
Users would just have to use track.locations.first() if they one the first one...
But it's not me, so it's up to you :D

Thanks, greatly appreciated !

@njh
Copy link
Owner

njh commented Apr 7, 2020

The reason for having both is because having a single location / music file is the more common case. And many file formats only support a single location.

@gordielachance
Copy link
Author

It's up to you, just wondering if this is not a little bit weird for a logic.
Any chance to have it working one of those days ?
Thanks.

@gordielachance
Copy link
Author

up ? thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants