Skip to content

Commit 974d0ad

Browse files
committed
Adressing review comments
1 parent 355ed67 commit 974d0ad

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

ReleaseNotes.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ In addition, the following issues were corrected:
88
- A minor bug in the rectangular matrix covariance block was corrected. The values for the row and column energies are lifted out of a larger array using the std::ranges::take and std::ranges::drop function. For the column energies, we forgot to properly end the sequence. As a result, the end() iterator of the range did not point to the end of the column energies but to the end of the covariance values, which is now corrected.
99
- In MF8 MT457 DiscreteSpectrum, NT=8 (which can occur for electrons, i.e. STYP=8), was explicitly disallowed by ENDFtk. This was corrected and a new constructor reflecting this usage was added as well.
1010
- The STA variable in MF1 MT451 was interpreted incorrectly and this has now been fixed. An additional isUnstable() function has been added to the interface.
11-
- The NJSX value (the number of spin groups) is now read from the CONT record before the particle pairs in MF32 R-matrix limited uncertainties since SAMMY does not print the NJSX value on the particle pairs (the ENDF format bascially has the NJSX value appear in two places and ENDFtk used the second one while SAMMY only prints out the first one). This "breaks" some interface functions (the R-matrix limited uncertainties from_string() function now requires the number of spin groups while previously it did not).
11+
- The NJSX value (the number of spin groups) is now read from the CONT record before the particle pairs in MF32 R-matrix limited uncertainties since SAMMY does not print the NJSX value on the particle pairs (the ENDF format basically has the NJSX value appear in two places and ENDFtk used the second one while SAMMY only prints out the first one). This "breaks" some interface functions (the R-matrix limited uncertainties from_string() function now requires the number of spin groups while previously it did not).
1212

1313
A few changes were also made to remove some range-v3 code in MF1 MT451. These changes have no impact on functionality.
1414

src/ENDFtk/section/32/151/CompactBreitWignerUncertainties/src/ctor.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,6 @@ CompactBreitWignerUncertainties( Iterator& it, const Iterator& end, long& lineNu
8888
*/
8989
template< typename Iterator >
9090
CompactBreitWignerUncertainties( Iterator& it, const Iterator& end, long& lineNumber,
91-
int MAT, int MF, int MT, int ) :
91+
int MAT, int MF, int MT, int /* unused */ ) :
9292
// no try ... catch: exceptions will be handled in the derived class
9393
CompactBreitWignerUncertainties( it, end, lineNumber, MAT, MF, MT ) {}

src/ENDFtk/section/32/151/CompactReichMooreUncertainties/src/ctor.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,6 @@ CompactReichMooreUncertainties( Iterator& it, const Iterator& end, long& lineNum
9090
*/
9191
template< typename Iterator >
9292
CompactReichMooreUncertainties( Iterator& it, const Iterator& end, long& lineNumber,
93-
int MAT, int MF, int MT, int ) :
93+
int MAT, int MF, int MT, int /* unused */ ) :
9494
// no try ... catch: exceptions will be handled in the derived class
9595
CompactReichMooreUncertainties( it, end, lineNumber, MAT, MF, MT ) {}

0 commit comments

Comments
 (0)