Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Way to add thousands and decimal separator to counter numbers? #128

Open
spencer-j opened this issue Feb 28, 2021 · 2 comments
Open

Way to add thousands and decimal separator to counter numbers? #128

spencer-j opened this issue Feb 28, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@spencer-j
Copy link

Hello, is there a way to add Separators to counter numbers
Greets spencer
@nk-o
Copy link
Collaborator

nk-o commented Mar 2, 2021

Hey Spencer.

It is not possible right now. Maybe in future releases, we can somehow improve this code

https://github.com/nk-o/ghostkit/blob/2a438f6c618d375677892684b79ae51ed4fc76e9/src/assets/js/main.js#L255-L337

@nk-o nk-o added the enhancement New feature or request label Mar 2, 2021
@spencer-j
Copy link
Author

spencer-j commented Mar 2, 2021 •
edited
Loading

Maybe its better to go with a library like e.g.
https://github.com/inorganik/countUp.js/
or jq plugin
https://github.com/garethdn/jquery-numerator
MIT Licence should also be ok with commercial gk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nk-o @spencer-j