Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: Heading appearance property #1145

Open
veslav3 opened this issue Jan 22, 2025 · 0 comments
Open

REFACTOR: Heading appearance property #1145

veslav3 opened this issue Jan 22, 2025 · 0 comments
Assignees
@Rerbun

Comments

@veslav3
Copy link
Contributor

veslav3 commented Jan 22, 2025

Op dit moment moet de appearance worden toegevoegd doormiddel van utrecht-heading-{nummer}, maar dit is een beetje raar om te gebruiken als gebruiker die niets met Utrecht te maken heeft.

Doel van deze story is om Heading om te bouwen zodat de appearance property simpeler is.

Zie voorbeeld van hoe dit is opgelost in Footer.tsx:

<Heading
  appearance={`utrecht-heading-${appearanceLevel >= MAX_APPEARANCE_HEADING_LEVEL ? MAX_APPEARANCE_HEADING_LEVEL : appearanceLevel}`}
  level={2}
>
  {heading}
</Heading>
@veslav3 veslav3 converted this from a draft issue Jan 22, 2025
@veslav3 veslav3 mentioned this issue Jan 22, 2025
Open
@Rerbun Rerbun changed the title REFACTOR: Heading appearance property? REFACTOR: Heading appearance property Jan 23, 2025
@Rerbun Rerbun self-assigned this Jan 23, 2025
@Rerbun Rerbun moved this from Todo to In Progress in Community Sprint - Rijkshuisstijl componenten Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rerbun Rerbun

Labels
None yet
Projects
Community Sprint - Rijkshuisstijl componenten
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rerbun @veslav3