Skip to content

Commit b987a9e

Browse files
RobbertYolijn
authored andcommitted
fix: avoid "list" role elements in Listbox
1 parent 1c16253 commit b987a9e

File tree

3 files changed

+22
-1
lines changed

3 files changed

+22
-1
lines changed

.changeset/twenty-bees-train.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@utrecht/listbox-react": patch
3+
---
4+
5+
Fix Listbox to only render "listbox" and "option" roles, and no "list" role from the `<ul>`.

packages/components-react/listbox-react/src/index.test.tsx

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,20 @@ describe('Listbox', () => {
3030
expect(listbox).toBeInTheDocument();
3131
});
3232

33+
it('renders no list role element', () => {
34+
render(<Listbox />);
35+
36+
let list;
37+
38+
try {
39+
list = screen.getByRole('list');
40+
} catch (e) {
41+
expect(e).toBeDefined();
42+
}
43+
44+
expect(list).not.toBeDefined();
45+
});
46+
3347
it('renders a design system BEM block class name', () => {
3448
const { container } = render(<Listbox />);
3549

packages/components-react/listbox-react/src/index.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,9 @@ export const Listbox = forwardRef(
5050
{...restProps}
5151
ref={ref}
5252
>
53-
<ul className="utrecht-listbox__list">{children}</ul>
53+
<ul className="utrecht-listbox__list" role="none">
54+
{children}
55+
</ul>
5456
</div>
5557
),
5658
);

0 commit comments

Comments
 (0)