From 2e729852a70e19e904db49975eeb328cfe9af9be Mon Sep 17 00:00:00 2001 From: MeesoPost <100311542+MeesoPost@users.noreply.github.com> Date: Mon, 23 Dec 2024 15:13:07 +0100 Subject: [PATCH 1/4] fix: remove background image from custom checkbox focus styles --- components/custom-checkbox/src/_mixin.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/components/custom-checkbox/src/_mixin.scss b/components/custom-checkbox/src/_mixin.scss index b3b407bf95f..69ed47214fe 100644 --- a/components/custom-checkbox/src/_mixin.scss +++ b/components/custom-checkbox/src/_mixin.scss @@ -84,7 +84,6 @@ @include utrecht-focus; background-color: var(--utrecht-checkbox-focus-background-color, var(--utrecht-checkbox-background-color)); - background-image: url("data:image/svg+xml,%3csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 20 20'%3e%3cpath fill='none' stroke='%23fff' stroke-linecap='round' stroke-linejoin='round' stroke-width='3' d='m6 10 3 3 6-6'/%3e%3c/svg%3e"); border-color: var(--utrecht-checkbox-focus-border-color, var(--utrecht-checkbox-border-color)); border-width: var(--utrecht-checkbox-focus-border-width, var(--utrecht-checkbox-border-width)); } From 34f1a32ff6f63b0b683450ffd649ffc379eeb6f2 Mon Sep 17 00:00:00 2001 From: MeesoPost <100311542+MeesoPost@users.noreply.github.com> Date: Mon, 23 Dec 2024 16:32:19 +0100 Subject: [PATCH 2/4] fix: remove background image from active custom checkbox styles --- components/custom-checkbox/src/_mixin.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/components/custom-checkbox/src/_mixin.scss b/components/custom-checkbox/src/_mixin.scss index 69ed47214fe..9111a3000c6 100644 --- a/components/custom-checkbox/src/_mixin.scss +++ b/components/custom-checkbox/src/_mixin.scss @@ -68,7 +68,6 @@ @mixin utrecht-custom-checkbox--active { background-color: var(--utrecht-checkbox-active-background-color, var(--utrecht-checkbox-background-color)); - background-image: url("data:image/svg+xml,%3csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 20 20'%3e%3cpath fill='none' stroke='%23fff' stroke-linecap='round' stroke-linejoin='round' stroke-width='3' d='m6 10 3 3 6-6'/%3e%3c/svg%3e"); border-color: var(--utrecht-checkbox-active-border-color, var(--utrecht-checkbox-border-color)); border-width: var(--utrecht-checkbox-active-border-width, var(--utrecht-checkbox-border-width)); color: var(--utrecht-checkbox-active-color, var(--utrecht-checkbox-color)); From 81b016dc7101dfdb5a376ad4781b270ef3516b12 Mon Sep 17 00:00:00 2001 From: MeesoPost <100311542+MeesoPost@users.noreply.github.com> Date: Mon, 23 Dec 2024 16:33:59 +0100 Subject: [PATCH 3/4] chore(changeset): custom-checkbox focus styles --- .changeset/clean-sloths-lick.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/clean-sloths-lick.md diff --git a/.changeset/clean-sloths-lick.md b/.changeset/clean-sloths-lick.md new file mode 100644 index 00000000000..1622c62c5e9 --- /dev/null +++ b/.changeset/clean-sloths-lick.md @@ -0,0 +1,5 @@ +--- +"@utrecht/custom-checkbox-css": minor +--- + +Remove SVG checkmark background image from checkbox :focus and :active states. From 50cccbcf546cd38baa0b3888978d6f4799ec97de Mon Sep 17 00:00:00 2001 From: Robbert Date: Tue, 24 Dec 2024 02:34:30 +0100 Subject: [PATCH 4/4] Apply suggestions from code review --- .changeset/clean-sloths-lick.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/clean-sloths-lick.md b/.changeset/clean-sloths-lick.md index 1622c62c5e9..91d405f7e39 100644 --- a/.changeset/clean-sloths-lick.md +++ b/.changeset/clean-sloths-lick.md @@ -1,5 +1,5 @@ --- -"@utrecht/custom-checkbox-css": minor +"@utrecht/custom-checkbox-css": patch --- Remove SVG checkmark background image from checkbox :focus and :active states.