Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Non-Testing Test #126

Open
boyleconnor opened this issue Jun 5, 2021 · 3 comments
Open

Fix Non-Testing Test #126

boyleconnor opened this issue Jun 5, 2021 · 3 comments
Assignees

Comments

@boyleconnor
Copy link
Collaborator

boyleconnor commented Jun 5, 2021

If you look closely at this unit test and its supporting mock_get_tool function, you'll see that the else: clause (returning "some-annotator") is getting called for every tool dependency.

@tschaffter
Copy link
Member

@cascadianblue The comment of the function highlighted refers to get_tool_dependencies but the mock is about get_tool. Is that the desired behavior?

@tschaffter tschaffter added Priority: Low question Further information is requested labels Jun 5, 2021
@tschaffter
Copy link
Member

@cascadianblue Should this issue be solved before release version 1.1.0?

@boyleconnor
Copy link
Collaborator Author

@tschaffter it is not urgent. It is just that the mock function is not performing like an actual API call. Not even sure if it is worth testing, and the actual tool is behaving in the correct/desired way as I have observed in real life.

@tschaffter tschaffter removed the question Further information is requested label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants