fix: compiler errors

Author: tnotheis

Applications/IdentityDeletionJobs/src/Job.IdentityDeletion/Workers/ActualDeletionWorker.cs

@@ -13,32 +13,35 @@ namespace Backbone.Job.IdentityDeletion.Workers;
 
 public class ActualDeletionWorker : IHostedService
 {
-    public static ILogger<ActualDeletionWorker> Logger = null!;
+    public static ILogger<ActualDeletionWorker>? Logger = null!;
 
     private readonly IHostApplicationLifetime _host;
     private readonly IMediator _mediator;
     private readonly IPushNotificationSender _pushNotificationSender;
+    private readonly ILogger<ActualDeletionWorker> _logger;
     private readonly List<IIdentityDeleter> _identityDeleters;
 
     public ActualDeletionWorker(
         IHostApplicationLifetime host,
         IEnumerable<IIdentityDeleter> identityDeleters,
         IMediator mediator,
-        IPushNotificationSender pushNotificationSender)
+        IPushNotificationSender pushNotificationSender,
+        ILogger<ActualDeletionWorker> logger)
     {
         _host = host;
         _identityDeleters = identityDeleters.ToList();
         _mediator = mediator;
         _pushNotificationSender = pushNotificationSender;
+        _logger = Logger ?? logger;
     }
 
     public async Task StartAsync(CancellationToken cancellationToken)
     {
-        Logger.LogError("StartAsync start");
+        _logger.LogError("StartAsync start");
         await StartProcessing(cancellationToken);
 
         _host.StopApplication();
-        Logger.LogError("StartAsync end");
+        _logger.LogError("StartAsync end");
     }
 
     public Task StopAsync(CancellationToken cancellationToken)
@@ -48,36 +51,36 @@ public Task StopAsync(CancellationToken cancellationToken)
 
     public async Task StartProcessing(CancellationToken cancellationToken)
     {
-        Logger.LogError("StartProcessing start");
+        _logger.LogError("StartProcessing start");
         var response = await _mediator.Send(new TriggerRipeDeletionProcessesCommand(), cancellationToken);
 
-        Logger.LogError("There are {count} ripe deletion processes to be executed", response.Results.Count);
+        _logger.LogError("There are {count} ripe deletion processes to be executed", response.Results.Count);
 
         var addressesWithTriggeredDeletionProcesses = response.Results.Where(x => x.Value.IsSuccess).Select(x => x.Key);
         var erroringDeletionTriggers = response.Results.Where(x => x.Value.IsFailure);
 
         await ExecuteDeletion(addressesWithTriggeredDeletionProcesses, cancellationToken);
         LogErroringDeletionTriggers(erroringDeletionTriggers);
-        Logger.LogError("StartProcessing end");
+        _logger.LogError("StartProcessing end");
     }
 
     private async Task ExecuteDeletion(IEnumerable<IdentityAddress> addresses, CancellationToken cancellationToken)
     {
-        Logger.LogError("ExecuteDeletion start");
+        _logger.LogError("ExecuteDeletion start");
         foreach (var identityAddress in addresses)
         {
             await ExecuteDeletion(identityAddress, cancellationToken);
         }
 
-        Logger.LogError("ExecuteDeletion end");
+        _logger.LogError("ExecuteDeletion end");
     }
 
     private async Task ExecuteDeletion(IdentityAddress identityAddress, CancellationToken cancellationToken)
     {
-        Logger.LogError("ExecuteDeletion start");
+        _logger.LogError("ExecuteDeletion start");
         await NotifyIdentityAboutStartingDeletion(identityAddress, cancellationToken);
         await Delete(identityAddress);
-        Logger.LogError("ExecuteDeletion end");
+        _logger.LogError("ExecuteDeletion end");
     }
 
     private async Task NotifyIdentityAboutStartingDeletion(IdentityAddress identityAddress, CancellationToken cancellationToken)
@@ -90,26 +93,26 @@ await _pushNotificationSender.SendNotification(
 
     private async Task Delete(IdentityAddress identityAddress)
     {
-        Logger.LogError("Delete start");
+        _logger.LogError("Delete start");
         var identity = await _mediator.Send(new GetIdentityQuery(identityAddress.Value));
 
         foreach (var identityDeleter in _identityDeleters)
         {
-            Logger.LogError("Executing {name}", identityDeleter.GetType().FullName);
+            _logger.LogError("Executing {name}", identityDeleter.GetType().FullName);
             await identityDeleter.Delete(identityAddress);
         }
 
         var usernames = identity.Devices.Select(d => d.Username);
 
         await _mediator.Send(new HandleCompletedDeletionProcessCommand(identityAddress.Value, usernames));
-        Logger.LogError("Delete end");
+        _logger.LogError("Delete end");
     }
 
     private void LogErroringDeletionTriggers(IEnumerable<KeyValuePair<IdentityAddress, UnitResult<DomainError>>> erroringDeletionTriggers)
     {
         foreach (var erroringDeletion in erroringDeletionTriggers)
         {
-            Logger.ErrorWhenTriggeringDeletionProcessForIdentity(erroringDeletion.Value.Error.Code, erroringDeletion.Value.Error.Message);
+            _logger.ErrorWhenTriggeringDeletionProcessForIdentity(erroringDeletion.Value.Error.Code, erroringDeletion.Value.Error.Message);
         }
     }
 }

Applications/IdentityDeletionJobs/test/Job.IdentityDeletion.Tests/Tests/ActualDeletionWorkerTests.cs

@@ -13,6 +13,7 @@
 using FakeItEasy;
 using MediatR;
 using Microsoft.Extensions.Hosting;
+using Microsoft.Extensions.Logging;
 
 namespace Backbone.Job.IdentityDeletion.Tests.Tests;
 
@@ -109,7 +110,8 @@ private static ActualDeletionWorker CreateWorker(IMediator mediator,
         var hostApplicationLifetime = A.Dummy<IHostApplicationLifetime>();
         identityDeleters ??= [A.Dummy<IIdentityDeleter>()];
         pushNotificationSender ??= A.Dummy<IPushNotificationSender>();
-        return new ActualDeletionWorker(hostApplicationLifetime, identityDeleters, mediator, pushNotificationSender);
+        var logger = A.Dummy<ILogger<ActualDeletionWorker>>();
+        return new ActualDeletionWorker(hostApplicationLifetime, identityDeleters, mediator, pushNotificationSender, logger);
     }
 
     private static Identity CreateIdentity()

BuildingBlocks/src/UnitTestTools/Data/TestDataGenerator.cs

@@ -16,7 +16,7 @@ public static string CreateRandomString(int resultLength, char[]? chars = null)
 
     public static IdentityAddress CreateRandomIdentityAddress()
     {
-        return IdentityAddress.Create(CreateRandomBytes(), "prod.enmeshed.eu");
+        return IdentityAddress.Create(CreateRandomBytes(), "localhost");
     }
 
     public static DeviceId CreateRandomDeviceId()

Modules/Relationships/src/Relationships.Application/Relationships/Commands/DecomposeAndAnonymizeRelationshipsOfIdentity/Handler.cs

@@ -11,7 +11,7 @@ namespace Backbone.Modules.Relationships.Application.Relationships.Commands.Deco
 
 public class Handler : IRequestHandler<DecomposeAndAnonymizeRelationshipsOfIdentityCommand>
 {
-    public static ILogger<Handler> Logger = null!;
+    public static ILogger<Handler>? Logger = null!;
 
     private readonly IRelationshipsRepository _relationshipsRepository;
     private readonly ApplicationOptions _applicationOptions;
@@ -26,16 +26,16 @@ public async Task Handle(DecomposeAndAnonymizeRelationshipsOfIdentityCommand req
     {
         var relationships = (await _relationshipsRepository.FindRelationships(Relationship.HasParticipant(request.IdentityAddress), cancellationToken)).ToList();
 
-        Logger.LogError("Decomposing {n} relationships for identity {IdentityAddress}", relationships.Count, request.IdentityAddress);
+        Logger?.LogError("Decomposing {n} relationships for identity {IdentityAddress}", relationships.Count, request.IdentityAddress);
 
         foreach (var relationship in relationships)
             relationship.DecomposeDueToIdentityDeletion(request.IdentityAddress, _applicationOptions.DidDomainName);
 
-        Logger.LogError("Done decomposing relationships for identity {IdentityAddress}", request.IdentityAddress);
+        Logger?.LogError("Done decomposing relationships for identity {IdentityAddress}", request.IdentityAddress);
 
         var rel = relationships.FirstOrDefault();
 
-        Logger.LogError("Relationship: {rel}", JsonSerializer.Serialize(rel, new JsonSerializerOptions
+        Logger?.LogError("Relationship: {rel}", JsonSerializer.Serialize(rel, new JsonSerializerOptions
         {
             ReferenceHandler = ReferenceHandler.IgnoreCycles,
             WriteIndented = true