New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is possible to cancel deletion processes with expired grace periods #989

Merged

tnotheis merged 2 commits into main from it-is-possible-to-cancel-deletion-processes-with-expired-grace-periods

Dec 16, 2024

Member

tnotheis commented Dec 16, 2024 •

edited

Loading

Readiness checklist

I added/updated unit tests.
I added/updated integration tests.
I ensured that the PR title is good enough for the changelog.
I labeled the PR.

tnotheis added 2 commits

December 16, 2024 15:58


          fix: throw if deletion grace period is expired

3355f71


          test: write a test for it

86dbfdb

tnotheis added the bug label

tnotheis requested a review from jkoenig134

December 16, 2024 14:59

tnotheis self-assigned this

tnotheis enabled auto-merge (squash)

December 16, 2024 14:59

jkoenig134 approved these changes

View reviewed changes

tnotheis merged commit b1d06b7 into main

26 checks passed

tnotheis deleted the it-is-possible-to-cancel-deletion-processes-with-expired-grace-periods branch

December 16, 2024 15:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug