Skip to content

Commit def6dfb

Browse files
committed
Remove break in the switch
1 parent 01dac38 commit def6dfb

File tree

5 files changed

+0
-21
lines changed

5 files changed

+0
-21
lines changed

auth/perm.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,10 @@ func ToPerm(perm string) (p Perm) {
8181
switch c {
8282
case ReadPerm:
8383
r = true
84-
break
8584
case WritePerm:
8685
w = true
87-
break
8886
case ExecutePerm:
8987
x = true
90-
break
9188
default:
9289
return p
9390
}

internal/signal/signal.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,13 @@ func Notify(shutdown func() error) {
1919
err := shutdown()
2020
if err != nil {
2121
log.Error(err, "shutdown error")
22-
break
2322
} else {
2423
signal.Stop(c)
2524
close(c)
2625
return
2726
}
2827
default:
2928
log.Debug("received a signal [%s], ignore it", s.String())
30-
break
3129
}
3230
}
3331
}

monitor/remote_client_monitor.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -232,16 +232,12 @@ func (m *remoteClientMonitor) parseMessage(data []byte) error {
232232
switch status.ApiType {
233233
case contract.AuthApi:
234234
m.authChan <- status
235-
break
236235
case contract.InfoApi:
237236
m.infoChan <- contract.NewMessage(data)
238-
break
239237
case contract.SyncMessageApi:
240238
m.messages.PushBack(contract.NewMessage(data))
241-
break
242239
default:
243240
log.Warn("remote client monitor received a unknown data => %s", string(data))
244-
break
245241
}
246242
return nil
247243
}
@@ -290,25 +286,20 @@ func (m *remoteClientMonitor) execSync(msg sync.Message) (err error) {
290286
switch msg.Action {
291287
case action.CreateAction:
292288
err = m.syncer.Create(path)
293-
break
294289
case action.WriteAction:
295290
err = m.syncer.Create(path)
296291
// ignore is not exist error
297292
if err != nil && os.IsNotExist(err) {
298293
err = nil
299294
}
300295
m.addWrite(path)
301-
break
302296
case action.RemoveAction:
303297
m.removeWrite(path)
304298
err = m.syncer.Remove(path)
305-
break
306299
case action.RenameAction:
307300
err = m.syncer.Rename(path)
308-
break
309301
case action.ChmodAction:
310302
err = m.syncer.Chmod(path)
311-
break
312303
}
313304

314305
m.el.Write(eventlog.NewEvent(path, msg.Action.String()))

server/handler/push_handler.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,16 +64,12 @@ func (h *pushHandler) Handle(c *gin.Context) {
6464
switch pushData.Action {
6565
case action.CreateAction:
6666
err = h.create(fi)
67-
break
6867
case action.RemoveAction:
6968
err = h.remove(fi)
70-
break
7169
case action.RenameAction:
7270
err = h.rename(fi)
73-
break
7471
case action.ChmodAction:
7572
err = h.chmod(fi)
76-
break
7773
case action.WriteAction:
7874
r, _ := h.write(pushData, c)
7975
c.JSON(http.StatusOK, r)

sync/push_client_sync.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,13 +177,10 @@ func (pcs *pushClientSync) receive() {
177177
switch status.ApiType {
178178
case contract.AuthApi:
179179
pcs.authChan <- status
180-
break
181180
case contract.InfoApi:
182181
pcs.infoChan <- contract.NewMessage(data)
183-
break
184182
default:
185183
log.Warn("[push client sync] receive and discard data => %s", string(data))
186-
break
187184
}
188185
}
189186
}

0 commit comments

Comments
 (0)