Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org-transclusion-fringe does not display in doom emacs #252

Open
osheari1 opened this issue Sep 10, 2024 · 3 comments · May be fixed by #253
Open

org-transclusion-fringe does not display in doom emacs #252

osheari1 opened this issue Sep 10, 2024 · 3 comments · May be fixed by #253

Comments

@osheari1
Copy link

When settings the fringe variables, the source frindge displays correctly, however the transclusion fringe does not.

(custom-set-faces! '(org-transclusion-fringe
                     :forground "#ebf6fa"
                     :background "#ebf6fa"))
(custom-set-faces! '(org-transclusion-source-fringe
                     :forground "#ebf6fa"
                     :background "#ebf6fa"))

In the code below, it seems that the call to overlay-put may be missing?

....
      (overlay-put ov-tc 'line-prefix (org-transclusion-propertize-transclusion))
      (overlay-put ov-tc 'wrap-prefix (org-transclusion-propertize-transclusion))
...

https://github.com/nobiot/org-transclusion/blob/main/org-transclusion.el#L1080

Screenshot_20240910_162628

@osheari1 osheari1 linked a pull request Sep 10, 2024 that will close this issue
@nobiot
Copy link
Owner

nobiot commented Sep 28, 2024

@osheari1 , I have spent some time testing the issue.

By the looks of the screen image above, do you have org-indent-mode turned on?

Can you check if the issue persists if it is turned off?

I can reproduce the problem only when I have org-indent-mode active. And we have a support for it with org-transclusion-indent-mode.

On my end, if I activate the org-transclusion-indent-mode, the transclusion fringe appears.

image

@osheari1
Copy link
Author

osheari1 commented Oct 30, 2024

Hey, thanks for testing this out.

I'll test this out as soon as I can. Apologies for the delay, the last couple months have been hectic.

@mkvoya
Copy link

mkvoya commented Dec 21, 2024

I encountered the same issue, and the transclusion-indent-mode works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants