From 432949a5a77fd47d3dcc852ebb07fc73cc4d796e Mon Sep 17 00:00:00 2001 From: Mateusz Hawrus <48822818+nieomylnieja@users.noreply.github.com> Date: Wed, 7 Feb 2024 10:19:44 +0100 Subject: [PATCH] fix: Unquote ldflags in Release workflow (#41) ## Motivation `LDFLAGS` Docker argument should not be quoted since this causes: ``` invalid value "'-s -w -X github.com/nobl9/sloctl/internal.BuildVersion=v0.0.98'" for flag -ldflags: parameter may not start with quote character ' ``` --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index dca008e..b2672fb 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -51,4 +51,4 @@ jobs: platforms: linux/amd64, linux/arm64 tags: ${{ steps.meta.outputs.tags }} labels: ${{ steps.meta.outputs.labels }} - build-args: LDFLAGS='-s -w -X github.com/nobl9/sloctl/internal.BuildVersion=${{ github.ref_name }}' + build-args: LDFLAGS=-s -w -X github.com/nobl9/sloctl/internal.BuildVersion=${{ github.ref_name }}