From 73b9b9209f0c306565f8bde556fe0b3a8018d62a Mon Sep 17 00:00:00 2001 From: Mateusz Hawrus <48822818+nieomylnieja@users.noreply.github.com> Date: Fri, 16 Feb 2024 16:41:56 +0100 Subject: [PATCH 1/2] chore: Update pr-title.yml (#54) ## Motivation Subscribe to synchronize events in order to alleviate pr-title workflow problems (it won't trigger sometimes). --- .github/workflows/pr-title.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-title.yml b/.github/workflows/pr-title.yml index 2d55ebf..2a77da5 100644 --- a/.github/workflows/pr-title.yml +++ b/.github/workflows/pr-title.yml @@ -1,6 +1,6 @@ on: pull_request: - types: [opened, reopened, edited] + types: [opened, reopened, edited, synchronize] merge_group: name: pr-title jobs: From 2dee59330a297b29aa91a5e15871eeed2c973367 Mon Sep 17 00:00:00 2001 From: Mateusz Hawrus <48822818+nieomylnieja@users.noreply.github.com> Date: Fri, 16 Feb 2024 16:49:10 +0100 Subject: [PATCH 2/2] chore: Update e2e-tests.yml (#55) ## Motivation Use transparent variable for client id so that we can track the secret ownership better. --- .github/workflows/e2e-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 6a74b6b..493cd7d 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -17,5 +17,5 @@ jobs: - name: Run tests run: make test/e2e env: - SLOCTL_CLIENT_ID: ${{ secrets.SLOCTL_CLIENT_ID }} + SLOCTL_CLIENT_ID: ${{ vars.SLOCTL_CLIENT_ID }} SLOCTL_CLIENT_SECRET: ${{ secrets.SLOCTL_CLIENT_SECRET }}