Fix ASCII Table shrinkage #629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the shrinkage of the table starting with Delimiter.
ccoVeille
reviewed
Sep 24, 2024
Comment on lines
+87
to
+94
| if indexes[0][0] == 0 { | ||
| if len(indexes) == 1 { | ||
| return src | ||
| } | ||
| dst = append(dst, src[0:indexes[0][1]]...) | ||
| s = indexes[0][1] | ||
| indexes = indexes[1:] | ||
| } |
There was a problem hiding this comment.
This code is so cryptic 😅
I'm thinking about using this just after you checked indexes is not empty
firstEntry := indexes[0]
Then you could use a better name than s for firstEntry[0]
Also adding comments won't kill you you know.
My message is somehow a "clean your room, mom" post it 😬😂
There was a problem hiding this comment.
Thank you for your comment.
It was difficult to understand and had a problem, so I will change it significantly.
|
This is closed because it was rebuilt with #631 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the shrinkage of the table starting with Delimiter.