Skip to content

Commit 29152a3

Browse files
committed
Update to newer version of rules_go and gazelle.
Now builds with go 1.12 (https://golang.org/doc/go1.12) which should result in better GC performance and memory usage.
1 parent 2c58c08 commit 29152a3

File tree

9 files changed

+6
-15
lines changed

9 files changed

+6
-15
lines changed

WORKSPACE

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ load("@gapid//tools/build:workspace_gapic.bzl", "gapic_dependencies", "gapic_thi
2424
gapic_dependencies()
2525
gapic_third_party()
2626

27-
load("@io_bazel_rules_go//go:def.bzl", "go_rules_dependencies", "go_register_toolchains")
27+
load("@io_bazel_rules_go//go:deps.bzl", "go_rules_dependencies", "go_register_toolchains")
2828
load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
2929
go_rules_dependencies()
3030
go_register_toolchains()

gapis/api/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ cc_proto_library(
130130

131131
go_proto_library(
132132
name = "api_go_proto",
133-
compilers = ["@io_bazel_rules_go//proto:go_grpc"],
134133
importpath = "github.com/google/gapid/gapis/api",
135134
proto = ":api_proto",
136135
visibility = ["//visibility:public"],

gapis/api/templates/api.proto.tmpl

+1-4
Original file line numberDiff line numberDiff line change
@@ -161,11 +161,8 @@
161161
162162
package {{$}};¶
163163
// cc_package¶
164+
option go_package = "{{$}}_pb";
164165
165166
import "gapis/memory/memory_pb/memory.proto";¶
166167
167168
{{end}}
168-
169-
170-
171-

gapis/memory/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ proto_library(
8787

8888
go_proto_library(
8989
name = "memory_go_proto",
90-
compilers = ["@io_bazel_rules_go//proto:go_grpc"],
9190
importpath = "github.com/google/gapid/gapis/memory",
9291
proto = ":memory_proto",
9392
visibility = ["//visibility:public"],

gapis/service/box/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ proto_library(
4242

4343
go_proto_library(
4444
name = "box_go_proto",
45-
compilers = ["@io_bazel_rules_go//proto:go_grpc"],
4645
importpath = "github.com/google/gapid/gapis/service/box",
4746
proto = ":box_proto",
4847
visibility = ["//visibility:public"],

gapis/service/path/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ proto_library(
5252

5353
go_proto_library(
5454
name = "path_go_proto",
55-
compilers = ["@io_bazel_rules_go//proto:go_grpc"],
5655
importpath = "github.com/google/gapid/gapis/service/path",
5756
proto = ":path_proto",
5857
visibility = ["//visibility:public"],

gapis/service/severity/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ proto_library(
2323

2424
go_proto_library(
2525
name = "severity_go_proto",
26-
compilers = ["@io_bazel_rules_go//proto:go_grpc"],
2726
importpath = "github.com/google/gapid/gapis/service/severity",
2827
proto = ":severity_proto",
2928
visibility = ["//visibility:public"],

gapis/vertex/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ proto_library(
3636

3737
go_proto_library(
3838
name = "vertex_go_proto",
39-
compilers = ["@io_bazel_rules_go//proto:go_grpc"],
4039
importpath = "github.com/google/gapid/gapis/vertex",
4140
proto = ":vertex_proto",
4241
visibility = ["//visibility:public"],

tools/build/workspace.bzl

+4-4
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ def gapid_dependencies(android = True, mingw = True, locals = {}):
3939
locals = locals,
4040
organization = "bazelbuild",
4141
project = "rules_go",
42-
commit = "01e5a9f8483167962eddd167f7689408bdeb4e76", # 0.16.3
43-
sha256 = "bd99a7620fd57d536103eedabd128e1ff95bd028a8cc2abbcdcf8c3026264fcc",
42+
commit = "3c34e66b0507056e83bcbd9c963ab9d7e6cb049f", # 0.18.3
43+
sha256 = "eee73ae5c29e421b2bfda62fef86ce266a942f66f19ccb4dfb03b4fa428986a5",
4444
)
4545

4646
maybe_repository(
@@ -49,8 +49,8 @@ def gapid_dependencies(android = True, mingw = True, locals = {}):
4949
locals = locals,
5050
organization = "bazelbuild",
5151
project = "bazel-gazelle",
52-
commit = "c728ce9f663e2bff26361ba5978ec5c9e6816a3c", # 0.15.0
53-
sha256 = "f7a066602430b3ccd3ab9db1aaf3197037d12af0cd82206cccf8961c3bfedb3b",
52+
commit = "e443c54b396a236e0d3823f46c6a931e1c9939f2", # 0.17.0
53+
sha256 = "ca6dcacc34c159784f01f557dbb0dc5d1772d3b28f1145b51f888ecb3694af1a",
5454
)
5555

5656
maybe_repository(

0 commit comments

Comments
 (0)