Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't support Daylight Savings Time #8

Open
vwbusguy opened this issue Mar 13, 2019 · 5 comments · May be fixed by #11
Open

Doesn't support Daylight Savings Time #8

vwbusguy opened this issue Mar 13, 2019 · 5 comments · May be fixed by #11

Comments

@vwbusguy
Copy link

It appears that tz-offset doesn't automatically adjust for Daylight Savings Time, making it late by one hour during DST periods.

Ref. node-cron/node-cron#157
Ref. https://github.com/node-cron/node-cron/blob/master/src/scheduled-task.js#L83

@vwbusguy
Copy link
Author

The offset appears to be hard-coded, which is why DST isn't recognized: https://github.com/node-cron/tz-offset/blob/master/generated/offsets.json

@tdeck
Copy link

tdeck commented Aug 23, 2020

Just ran into this today. I know it can be tough to maintain FOSS libraries but this one really should have a warning that it's not ready to use. A cron library that runs things at the wrong time is pretty much a non-starter.

@GarethRoddy
Copy link

I'm very surprised that DST isn't handled.. this seems crazy.

@meeratony
Copy link

meeratony commented Jan 23, 2021

Can you please approve his change request and merge it in... it will be so much easier to have node-cron consider DST

@tanosaur
Copy link

It's still not working - on node-cron version 3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants