-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't support Daylight Savings Time #8
Comments
The offset appears to be hard-coded, which is why DST isn't recognized: https://github.com/node-cron/tz-offset/blob/master/generated/offsets.json |
Just ran into this today. I know it can be tough to maintain FOSS libraries but this one really should have a warning that it's not ready to use. A cron library that runs things at the wrong time is pretty much a non-starter. |
I'm very surprised that DST isn't handled.. this seems crazy. |
Can you please approve his change request and merge it in... it will be so much easier to have node-cron consider DST |
It's still not working - on node-cron version 3.0.2 |
It appears that tz-offset doesn't automatically adjust for Daylight Savings Time, making it late by one hour during DST periods.
Ref. node-cron/node-cron#157
Ref. https://github.com/node-cron/node-cron/blob/master/src/scheduled-task.js#L83
The text was updated successfully, but these errors were encountered: