Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NpmTask workingDir should be DirectoryProperty #305

Open
wakingrufus opened this issue Feb 21, 2024 · 1 comment
Open

NpmTask workingDir should be DirectoryProperty #305

wakingrufus opened this issue Feb 21, 2024 · 1 comment

Comments

@wakingrufus
Copy link

NpmTask's workingDir property is currently a RegularFileProperty but it probably should be a DirectoryProperty similar to how NodeTask's workingDir property is.

I can implement this, if you wish, but I am not sure how you would want to handle breaking compatibility with existing code.

@deepy
Copy link
Member

deepy commented Mar 9, 2024

Next version is going to be a major so feel free to send a PR :-)
And no tests breaks with the change either, so this was potentially just an oversight when we moved to providers and properties 4 years ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants