Skip to content

Commit aadbc75

Browse files
committed
add test
1 parent fbeda20 commit aadbc75

File tree

1 file changed

+49
-1
lines changed

1 file changed

+49
-1
lines changed

test/validator.js

Lines changed: 49 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,53 @@ Date: Sat Oct 22 10:22:43 2022 +0200
171171
This reverts commit 01bc8e6fd81314e76c7fb0d09e5310f609e48bee.
172172
`
173173

174+
const str13 = `commit 287d681575bdd2099b0cc892f6a90b0323033101
175+
Author: Stephen Belanger <admin@stephenbelanger.com>
176+
Date: Wed Jul 24 10:00:04 2024 -0700
177+
178+
deps: V8: backport 7857eb34db42
179+
180+
Original commit message:
181+
182+
Reland^2 "Add ContinuationPreservedEmbedderData builtins to extras binding"
183+
184+
This reverts commit cb1277e97a0ed32fd893be9f4e927f6e8b6c566c.
185+
186+
> Original change's description:
187+
> > Add ContinuationPreservedEmbedderData builtins to extras binding
188+
> >
189+
> > Node.js and Deno wish to use CPED for AsyncLocalStorage and APM, which
190+
> > needs a high performance implementation. These builtins allow JavaScript
191+
> > to handle CPED performantly.
192+
> >
193+
> > Change-Id: I7577be80818524baa52791dfce57d442d7c0c933
194+
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5638129
195+
> > Commit-Queue: snek <snek@chromium.org>
196+
> > Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
197+
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
198+
> > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
199+
> > Cr-Commit-Position: refs/heads/main@{#94607}
200+
>
201+
> Change-Id: Ief390f0b99891c8de83b4c794180440f91cbaf1f
202+
> No-Presubmit: true
203+
> No-Tree-Checks: true
204+
> No-Try: true
205+
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5649024
206+
> Auto-Submit: Shu-yu Guo <syg@chromium.org>
207+
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
208+
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
209+
> Cr-Commit-Position: refs/heads/main@{#94608}
210+
211+
Change-Id: I4943071ffe192084e83bfe3113cfe9c92ef31465
212+
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5677045
213+
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
214+
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
215+
Commit-Queue: snek <snek@chromium.org>
216+
Cr-Commit-Position: refs/heads/main@{#94866}
217+
218+
Refs: v8/v8@7857eb3
219+
`
220+
174221
test('Validator - misc', (t) => {
175222
const v = new Validator()
176223

@@ -472,14 +519,15 @@ test('Validator - real commits', (t) => {
472519
const v = new Validator({
473520
'validate-no-metadata': true
474521
})
522+
tt.plan(2)
475523
v.lint(str5)
524+
v.lint(str13)
476525
v.on('commit', (data) => {
477526
const msgs = data.messages
478527
const filtered = msgs.filter((item) => {
479528
return item.level === 'fail'
480529
})
481530
tt.equal(filtered.length, 0, 'messages.length')
482-
tt.end()
483531
})
484532
})
485533

0 commit comments

Comments
 (0)