From c7a2615bffd731b4cfce41aafbf7eb416780b03b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sat, 27 Apr 2024 17:03:48 +0200 Subject: [PATCH 1/2] fix: support empty dictionary keys in input Certain old keys in `msvs_settings` (like "LinkIncremental") are moved to the top level when translated to `msbuild_settings`. This change allows to set them when `msbuild_settings` are authored directly. --- pylib/gyp/input.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pylib/gyp/input.py b/pylib/gyp/input.py index 6b61e4e2..926fff63 100644 --- a/pylib/gyp/input.py +++ b/pylib/gyp/input.py @@ -2536,6 +2536,8 @@ def ProcessListFiltersInDict(name, the_dict): lists = [] del_lists = [] for key, value in the_dict.items(): + if key == "": + continue operation = key[-1] if operation not in {"!", "/"}: continue From bf8f56bb56655eaba1c895c4c4b72789e14b4091 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sat, 27 Apr 2024 18:49:00 +0200 Subject: [PATCH 2/2] Update pylib/gyp/input.py Co-authored-by: Christian Clauss --- pylib/gyp/input.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pylib/gyp/input.py b/pylib/gyp/input.py index 926fff63..7150269c 100644 --- a/pylib/gyp/input.py +++ b/pylib/gyp/input.py @@ -2536,7 +2536,7 @@ def ProcessListFiltersInDict(name, the_dict): lists = [] del_lists = [] for key, value in the_dict.items(): - if key == "": + if not key: continue operation = key[-1] if operation not in {"!", "/"}: