Fix MyObject memory leak in some napi examples (#589)

nodejs · Feb 7, 2025 · 2c8b9e4 · 2c8b9e4
1 parent 92a4254
commit 2c8b9e4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/1-getting-started/6_object_wrap/napi/myobject.cc b/src/1-getting-started/6_object_wrap/napi/myobject.cc
@@ -11,7 +11,7 @@ MyObject::~MyObject() {
 void MyObject::Destructor(napi_env env,
                           void* nativeObject,
                           void* /*finalize_hint*/) {
-  reinterpret_cast<MyObject*>(nativeObject)->~MyObject();
+  delete reinterpret_cast<MyObject*>(nativeObject);
 }
 
 #define DECLARE_NAPI_METHOD(name, func)                                        \

diff --git a/src/1-getting-started/7_factory_wrap/napi/myobject.cc b/src/1-getting-started/7_factory_wrap/napi/myobject.cc
@@ -10,7 +10,7 @@ MyObject::~MyObject() {
 void MyObject::Destructor(napi_env env,
                           void* nativeObject,
                           void* /*finalize_hint*/) {
-  reinterpret_cast<MyObject*>(nativeObject)->~MyObject();
+  delete reinterpret_cast<MyObject*>(nativeObject);
 }
 
 #define DECLARE_NAPI_METHOD(name, func)                                        \

diff --git a/src/2-js-to-native-conversion/8_passing_wrapped/napi/myobject.cc b/src/2-js-to-native-conversion/8_passing_wrapped/napi/myobject.cc
@@ -10,7 +10,7 @@ MyObject::~MyObject() {
 void MyObject::Destructor(napi_env env,
                           void* nativeObject,
                           void* /*finalize_hint*/) {
-  reinterpret_cast<MyObject*>(nativeObject)->~MyObject();
+  delete reinterpret_cast<MyObject*>(nativeObject);
 }
 
 napi_status MyObject::Init(napi_env env) {