Skip to content

npm v12 removes command-line options #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cclauss wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −16
Open

npm v12 removes command-line options #3261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f847da5
npm v12 removes command-line options
cclauss Jan 4, 2026
1a17da7
Merge branch 'main' into npm_--msvs-version__and_--python
cclauss Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ jobs:
with:
python-version: ${{ matrix.python }}
allow-prereleases: true
- run: py --list-paths || true # Show all Python paths on Windows
- uses: seanmiddleditch/gha-setup-ninja@v6
- name: Install wasi-sdk (Windows)
shell: pwsh
Expand Down Expand Up @@ -163,15 +164,19 @@ jobs:
echo 'GYP_MSVS_OVERRIDE_PATH=C:\\Dummy' >> $Env:GITHUB_ENV
- name: Run Python Tests
run: python -m pytest
- name: Run Tests (macOS or Linux)
- name: Run Tests (Linux or macOS)
if: runner.os != 'Windows'
shell: bash
run: npm test --python="${pythonLocation}/python"
env:
FULL_TEST: ${{ (matrix.node == '24.x' && matrix.python == '3.14') && '1' || '0' }}
NODE_GYP_FORCE_PYTHON: "${{ env.pythonLocation }}/python"
run: npm test
- name: Run Tests (Windows)
if: runner.os == 'Windows'
shell: bash # Building wasm on Windows requires using make generator, it only works in bash
run: npm run test --python="${pythonLocation}\\python.exe"
env:
FULL_TEST: ${{ (matrix.node == '24.x' && matrix.python == '3.14') && '1' || '0' }}
NODE_GYP_FORCE_PYTHON: "${{ env.pythonLocation }}\\python.exe"
run: |
echo "NODE_GYP_FORCE_PYTHON=${NODE_GYP_FORCE_PYTHON}"
npm run test
7 changes: 5 additions & 2 deletions .github/workflows/visual-studio.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ jobs:
python-version: "3.x"
- name: Install Dependencies
run: npm install
# - run: echo "pythonLocation=${pythonLocation}"
- run: echo "env:pythonLocation=${env:pythonLocation}"
# - run: env
- name: Run Node tests
shell: pwsh
run: npm run test --python="${env:pythonLocation}\\python.exe" --msvs-version="${{ matrix.msvs-version }}"
shell: bash # Building wasm on Windows requires using make generator, it only works in bash
run: npm run test
16 changes: 6 additions & 10 deletions gyp/.github/workflows/node-gyp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ jobs:
- uses: actions/setup-node@v6
with:
node-version: "lts/*"
- uses: actions/setup-python@v6
- name: Use Python ${{ matrix.python-version }}
uses: actions/setup-python@v6
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
Expand All @@ -51,14 +52,9 @@ jobs:
run: |
rm -rf node-gyp/gyp
cp -r gyp-next node-gyp/gyp
- name: Run tests (macOS or Linux)
if: runner.os != 'Windows'
- run: echo "env:pythonLocation=${env:pythonLocation}"
# - run: env
- name: Run tests
run: |
cd node-gyp
npm test --python="${pythonLocation}/python"
- name: Run tests (Windows)
if: runner.os == 'Windows'
shell: pwsh
run: |
cd node-gyp
npm run test --python="${env:pythonLocation}\\python.exe"
npm test