-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"URL.parse()" works differently in diff versions of Nodejs #49024
Comments
cc @nodejs/url |
The ada library has no issue with this URL: cc @anonrig |
I think this issue is related to the missing backport in v18. Does this issue occur in latest node 20 or main branch? |
Yes.
For Nodejs 20 or the other versions, They're all right with me. PS: Even in Nodejs 18.14.X, it works properly. |
Looks like a missing backport to 18? cc @anonrig |
Maybe #48873? |
Backport has landed in the staging branch, and will be released in the next couple of days. |
Version
18.17.0 or 18.16.X
Platform
N/A (including Windows, Mac and Linux)
Subsystem
N/A
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
Always,without a required condition
What is the expected behavior? Why is that the expected behavior?
Works properly as what we see in the previous version (Before Node 18.17.0、18.16.X, it works fine without any exceptions).
What do you see instead?
TypeError [ERR_INVALID_URL]: Invalid URL\n' +
' at new NodeError (node:internal/errors:405:5)\n' +
' at Url.parse (node:url:445:17)\n' +
' at new urlParse (node:url:167:13)\n'
Additional information
This ONLY happens in Nodejs since 18.17.0 or 18.16.X, I cannot reproduce it any more in the other versions of Nodejs (Even in the previous versions of Nodejs like "18.14.X", we cannot reproduce it.....
When I change "300.149.250.173" to "www.randomAddress.com", everything works fine, why (I mean it seems I cannot use numeric address but Latin-based address....)?
The text was updated successfully, but these errors were encountered: