-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: fix client async storage persistence #55460
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55460 +/- ##
==========================================
- Coverage 88.41% 88.41% -0.01%
==========================================
Files 653 653
Lines 187435 187444 +9
Branches 36077 36075 -2
==========================================
+ Hits 165714 165720 +6
+ Misses 14960 14951 -9
- Partials 6761 6773 +12
|
I'll try to improve it and use internals instead of AsyncResource. |
I didn't find a better solution. Open for suggestions :) |
@mcollina Any comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
However I'm concerned that this will add overhead.
Are headers received only once per stream? If they are, we can unset the resource after using it in |
Create and store an AsyncResource for each stream, following a similar approach as used in HttpAgent. Fixes: nodejs#55376
Renamed |
The failures are unrelated to my changes.
https://ci.nodejs.org/job/node-test-commit-osx-arm/17293/nodes=osx11/console
Is it possible to retrigger these? |
Create and store an AsyncResource for each stream, following a similar approach as used in HttpAgent.
Fixes #55376