Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix nits in esm.md #15315

Closed
wants to merge 3 commits into from
Closed

doc: fix nits in esm.md #15315

wants to merge 3 commits into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc

To ease review, this PR is splitted in 2 commits:

  1. Fix nits.
  2. Wrap long lines.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 10, 2017
cjihrig
cjihrig approved these changes Sep 10, 2017
View reviewed changes
doc/api/esm.md Outdated
@@ -6,17 +6,21 @@

<!--name=esm-->

Node contains support for ES Modules based upon the [the Node EP for ES Modules][].
Node.js contains support for ES Modules based upon the
[the Node.js EP for ES Modules][].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the the" -> "the"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@vsemozhetbyt
Copy link
Contributor Author

Landed in b4b7ac6

vsemozhetbyt added a commit that referenced this pull request Sep 13, 2017
@vsemozhetbyt
doc: fix nits in esm.md
b4b7ac6 
* Fix some abbreviated wording, a typo and a link.
* Wrap long lines at 80 characters.

PR-URL: #15315
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@vsemozhetbyt vsemozhetbyt deleted the esm.md branch September 13, 2017 13:59
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@vsemozhetbyt @addaleax
doc: fix nits in esm.md
163a192 
* Fix some abbreviated wording, a typo and a link.
* Wrap long lines at 80 characters.

PR-URL: nodejs#15315
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@vsemozhetbyt @jasnell
doc: fix nits in esm.md
38422d5 
* Fix some abbreviated wording, a typo and a link.
* Wrap long lines at 80 characters.

PR-URL: #15315
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vsemozhetbyt @jasnell @lpinca @targos @cjihrig @tniessen @MylesBorins @nodejs-github-bot