Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable vercel preview on translations PRs #7324

Closed
bmuenzenmeyer opened this issue Dec 9, 2024 · 7 comments
Closed

Enable vercel preview on translations PRs #7324

bmuenzenmeyer opened this issue Dec 9, 2024 · 7 comments
Labels
i18n Issues/PRs related to the Website Internationalisation infrastructure Issues/PRs related to the Repository Infra

Comments

@bmuenzenmeyer
Copy link
Collaborator

PRs like #7321 would be greatly aided in their quality assurance if we allowed previews to be built from them.

Historically, our integration was pushing batches of commits which was very noisy. These now come in as a single commit, so it is not as wasteful in CI or noisy to maintainers
@bmuenzenmeyer bmuenzenmeyer added i18n Issues/PRs related to the Website Internationalisation infrastructure Issues/PRs related to the Repository Infra labels Dec 9, 2024
@bmuenzenmeyer bmuenzenmeyer mentioned this issue Dec 16, 2024
Merged
@bmuenzenmeyer

This comment has been minimized.

Sign in to view
@bmuenzenmeyer

This comment has been minimized.

Sign in to view
@bmuenzenmeyer bmuenzenmeyer mentioned this issue Dec 17, 2024
Merged
5 tasks
@AugustinMauroy

This comment has been minimized.

Sign in to view
@ovflowd

This comment has been minimized.

Sign in to view
@ovflowd

This comment has been minimized.

Sign in to view
@bmuenzenmeyer
Copy link
Collaborator Author

everything should be good to go - the next sync via GH Action or workflow dispatch -should- trigger a vercel preview

@bmuenzenmeyer
Copy link
Collaborator Author

#7343 created the preview 💃 🕺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
i18n Issues/PRs related to the Website Internationalisation infrastructure Issues/PRs related to the Repository Infra
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmuenzenmeyer @ovflowd @AugustinMauroy