Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle missing vary header values #4031

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: handle missing vary header values #4031

wants to merge 2 commits into from
+166 −22

Conversation

gurgunday
Copy link
Contributor

fixes: #3959

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 27, 2025
View reviewed changes
test/types/cache-interceptor.test-d.ts Fixed Show fixed Hide fixed
test/types/cache-interceptor.test-d.ts Fixed Show fixed Hide fixed
test/utils/cache.js Fixed Show fixed Hide fixed
test/utils/cache.js Fixed Show fixed Hide fixed
mcollina
mcollina reviewed Jan 28, 2025
View reviewed changes
test/issue-3959.js Outdated Show resolved Hide resolved
test/utils/cache.js Outdated Show resolved Hide resolved
lib/util/cache.js Show resolved Hide resolved
metcoder95
metcoder95 approved these changes Jan 28, 2025
View reviewed changes
lib/util/cache.js Show resolved Hide resolved
test/issue-3959.js Show resolved Hide resolved
@gurgunday gurgunday requested a review from mcollina January 28, 2025 19:00
@gurgunday
Copy link
Contributor Author

@KhafraDev can you take a look as well?

This issue recently bit me too

@gurgunday
Copy link
Contributor Author

gurgunday commented Feb 1, 2025 •
edited
Loading

Cc @flakey5, just saw your PR but leaving it here if you want to merge this one

It fixes both the undercase problem and the cache issue

@gurgunday gurgunday requested a review from metcoder95 February 1, 2025 12:15
flakey5
flakey5 suggested changes Feb 2, 2025
View reviewed changes
Copy link
Member

@flakey5 flakey5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue looks to be still present when using the sqlite cache store?
image

test/utils/cache.js Outdated
const assert = require('node:assert')
const { parseVaryHeader } = require('../../lib/util/cache.js')

describe('parseVaryHeader', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit but could you move these to where the other tests are for this function?

undici/test/cache-interceptor/utils.js

Line 179 in a9176c9

describe('parseVaryHeader', () => {

@gurgunday @flakey5
fix: handle missing vary header values
85c7843 
Co-authored-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@gurgunday
Copy link
Contributor Author

gurgunday commented Feb 2, 2025 •
edited
Loading

Yeah had to go back to null, it works better with JSON 😁

@gurgunday gurgunday requested a review from flakey5 February 2, 2025 19:44
@flakey5 flakey5 mentioned this pull request Feb 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flakey5 flakey5 flakey5 approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

@mcollina mcollina Awaiting requested review from mcollina

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response headers vary: Accept-Encoding is stopping undici from caching the http request
4 participants
@gurgunday @mcollina @metcoder95 @flakey5