From f2fc8efb165dd27436e80e147bd15828e0ba31ca Mon Sep 17 00:00:00 2001 From: Santiago Gimeno Date: Thu, 16 Nov 2023 14:51:55 +0100 Subject: [PATCH] src: change EnvList::promise_tracking_() signature Pass directly the SharedEnvInst. PR-URL: https://github.com/nodesource/nsolid/pull/25 Reviewed-by: Trevor Norris --- src/nsolid/nsolid_api.cc | 7 +++---- src/nsolid/nsolid_api.h | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/nsolid/nsolid_api.cc b/src/nsolid/nsolid_api.cc index a418fac1b4..a9a3a9ad05 100644 --- a/src/nsolid/nsolid_api.cc +++ b/src/nsolid/nsolid_api.cc @@ -1557,8 +1557,7 @@ void EnvList::gen_ptiles_cb_(ns_timer*) { } -void EnvList::promise_tracking_(const EnvInst& envinst, bool track) { - SharedEnvInst envinst_sp = EnvInst::GetInst(envinst.thread_id()); +void EnvList::promise_tracking_(SharedEnvInst envinst_sp, bool track) { Environment* env = envinst_sp->env(); if (env->nsolid_track_promises_fn().IsEmpty() || !envinst_sp->can_call_into_js()) { @@ -1581,12 +1580,12 @@ void EnvList::promise_tracking_(const EnvInst& envinst, bool track) { void EnvList::enable_promise_tracking_(SharedEnvInst envinst_sp, void*) { - EnvList::promise_tracking_(*envinst_sp.get(), true); + EnvList::promise_tracking_(envinst_sp, true); } void EnvList::disable_promise_tracking_(SharedEnvInst envinst_sp, void*) { - EnvList::promise_tracking_(*envinst_sp.get(), false); + EnvList::promise_tracking_(envinst_sp, false); } diff --git a/src/nsolid/nsolid_api.h b/src/nsolid/nsolid_api.h index c6aa9f3ccd..199d3e731a 100644 --- a/src/nsolid/nsolid_api.h +++ b/src/nsolid/nsolid_api.h @@ -594,7 +594,7 @@ class EnvList { static void blocked_loop_timer_cb_(nsuv::ns_timer*); static void gen_ptiles_cb_(nsuv::ns_timer*); static void raw_metrics_timer_cb_(nsuv::ns_timer*); - static void promise_tracking_(const EnvInst& envinst, bool track); + static void promise_tracking_(SharedEnvInst envinst_sp, bool track); static void enable_promise_tracking_(SharedEnvInst envinst_sp, void*); static void disable_promise_tracking_(SharedEnvInst envinst_sp, void*); static void update_has_metrics_stream_hooks(SharedEnvInst, bool has_metrics);