Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Field types from calldata lazily in brillig #7009

Open
TomAFrench opened this issue Jan 9, 2025 · 0 comments
Open

Load Field types from calldata lazily in brillig #7009

TomAFrench opened this issue Jan 9, 2025 · 0 comments

Comments

@TomAFrench
Copy link
Member

Currently during brillig codegen we always immediately copy all of the arguments out of calldata and into memory.

https://github.com/noir-lang/noir/blob/master/compiler/noirc_evaluator/src/brillig/brillig_ir/entry_point.rs#L152-L184

This works but is a bit wasteful as we can read these values from calldata at any time. One optimization we could then do is have any reference to a Field type argument load this directly from calldata when needed rather than preemptively loading it into memory.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant